Align Dependabot coverage and add the dev-fast build fragment - #15
Draft
leynos wants to merge 3 commits into
Draft
Align Dependabot coverage and add the dev-fast build fragment#15leynos wants to merge 3 commits into
leynos wants to merge 3 commits into
Conversation
Bring `.github/dependabot.yml` to the estate baseline: one update stanza per package ecosystem the repository uses, each labelled `dependencies` plus its channel label, with GitHub Actions updates batched into a single pull request via a wildcard group. Add the opt-in dev-fast build fragment at `tools/dev-fast/config.toml` (Cranelift codegen for the dev profile and the mold linker on Linux) with `dev-build` and `dev-test` Make targets that pass it explicitly via `--config`, and signpost the workflow in `AGENTS.md`. Release, coverage, and verification builds are unaffected: the fragment is never auto-discovered.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Reviewer's GuideAligns Dependabot configuration with the canonical baseline and introduces an opt-in dev-fast build fragment with new Make targets and documentation signposting. Sequence diagram for opt-in dev-fast build targetssequenceDiagram
actor Developer
participant Makefile
participant Cargo
participant dev_fast_config_toml as tools_dev_fast_config_toml
participant NightlyToolchain
participant MoldLinker
Developer->>Makefile: make dev-build
Makefile->>Cargo: cargo --config DEV_FAST_CONFIG build
Cargo->>dev_fast_config_toml: load config.toml
Cargo->>NightlyToolchain: use codegen-backend cranelift
Cargo->>MoldLinker: use -Clink-arg=-fuse-ld=mold [linux]
Developer->>Makefile: make dev-test
Makefile->>Cargo: cargo --config DEV_FAST_CONFIG test
Cargo->>dev_fast_config_toml: load config.toml
Cargo->>NightlyToolchain: use codegen-backend cranelift
Cargo->>MoldLinker: use -Clink-arg=-fuse-ld=mold [linux]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Estate review flagged two defects in the fragment's deployed comments: a stale "copy this fragment" instruction that reads as nonsense once the file is in place, and a mis-statement of Cargo's rustflags semantics (Cargo joins the entries of every matching `[target.*]` table; only the joined result takes precedence over `[build].rustflags` rather than merging). Both are corrected in the canonical source; take its bytes verbatim. No configuration key changes.
Estate review flagged that the appended dev-build and dev-test recipes hard-code `cargo` although the Makefile exposes an injectable `CARGO` variable, hiding the process dependency at the command boundary. Route both recipes through `$(CARGO)`, mirroring the companion branch byte-for-byte so the two open pull requests merge cleanly in either order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch applies Wave 1 of the Rust estate baseline remediation
(Operation Parabellum, phase 2). It aligns
.github/dependabot.yml
with the canonical Dependabot reference: one update stanza per package
ecosystem the repository uses (
cargo,rust-toolchain,github-actions), each stanza labelleddependenciesplus its channel label, and GitHub Actions updates batchedinto a single pull request via a wildcard group. It also adds the opt-in dev-fast build
fragment with
dev-buildanddev-testMake targets, signposted inAGENTS.md.
Review walkthrough
.github/dependabot.yml
for the ecosystem coverage and labels.
tools/dev-fast/config.toml
— a copy of the canonical fragment — and the
dev-build/dev-testtargets appended to the
Makefile.
AGENTS.md.
Validation
dependabot-baselineandrust-dev-fast-baseline:dependabot-baselinecompliant,rust-dev-fast-baselinenoncompliant.Notes
configuration references) were created on the repository ahead of this
pull request, so no stanza names a missing label.
applied when passed explicitly with
--config, so continuousintegration, release, coverage, and verification builds are untouched.
The targets need a nightly toolchain and, on Linux, a
moldbinary onthe
PATH; repositories still pinned to stable gain the wiring now andthe capability when Wave 2 moves the pin to nightly.
Summary by Sourcery
Align Dependabot configuration with Rust toolchain coverage and introduce an opt-in fast debug build workflow for local development.
New Features:
Enhancements:
Build:
CI: