Skip to content

Align Dependabot coverage and add the dev-fast build fragment - #15

Draft
leynos wants to merge 3 commits into
mainfrom
parabellum-wave-1
Draft

Align Dependabot coverage and add the dev-fast build fragment#15
leynos wants to merge 3 commits into
mainfrom
parabellum-wave-1

Conversation

@leynos

@leynos leynos commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

This branch applies Wave 1 of the Rust estate baseline remediation
(Operation Parabellum, phase 2). It aligns
.github/dependabot.yml
with the canonical Dependabot reference: one update stanza per package
ecosystem the repository uses (cargo, rust-toolchain, github-actions), each stanza labelled
dependencies plus its channel label, and GitHub Actions updates batched
into a single pull request via a wildcard group. It also adds the opt-in dev-fast build
fragment with dev-build and dev-test Make targets, signposted in
AGENTS.md.

Review walkthrough

Validation

  • Audited the amended tree with the Concordat rule packages
    dependabot-baseline and rust-dev-fast-baseline: dependabot-baseline compliant, rust-dev-fast-baseline noncompliant.

Notes

  • The canonical labels (including the Dependabot channel labels this
    configuration references) were created on the repository ahead of this
    pull request, so no stanza names a missing label.
  • The dev-fast fragment is strictly opt-in local tooling: it is only
    applied when passed explicitly with --config, so continuous
    integration, release, coverage, and verification builds are untouched.
    The targets need a nightly toolchain and, on Linux, a mold binary on
    the PATH; repositories still pinned to stable gain the wiring now and
    the capability when Wave 2 moves the pin to nightly.
  • Needs a human eye: .cargo/config.toml mentions cranelift.

Summary by Sourcery

Align Dependabot configuration with Rust toolchain coverage and introduce an opt-in fast debug build workflow for local development.

New Features:

  • Add nightly-based dev-build and dev-test Make targets that use an opt-in Cargo config for Cranelift and mold-accelerated debug builds.

Enhancements:

  • Document the fast development build targets and their constraints in AGENTS.md to guide local developer usage.

Build:

  • Add a canonical dev-fast Cargo config fragment for accelerated local debug builds without impacting release or CI builds.

CI:

  • Extend Dependabot coverage to manage rust-toolchain updates with appropriate dependency labelling and scheduling.

Bring `.github/dependabot.yml` to the estate baseline: one update
stanza per package ecosystem the repository uses, each labelled
`dependencies` plus its channel label, with GitHub Actions updates
batched into a single pull request via a wildcard group.

Add the opt-in dev-fast build fragment at
`tools/dev-fast/config.toml` (Cranelift codegen for the dev profile
and the mold linker on Linux) with `dev-build` and `dev-test` Make
targets that pass it explicitly via `--config`, and signpost the
workflow in `AGENTS.md`. Release, coverage, and verification builds
are unaffected: the fragment is never auto-discovered.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 644cb1c1-7951-4038-9903-15b4879a0913

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Reviewer's Guide

Aligns Dependabot configuration with the canonical baseline and introduces an opt-in dev-fast build fragment with new Make targets and documentation signposting.

Sequence diagram for opt-in dev-fast build targets

sequenceDiagram
  actor Developer
  participant Makefile
  participant Cargo
  participant dev_fast_config_toml as tools_dev_fast_config_toml
  participant NightlyToolchain
  participant MoldLinker

  Developer->>Makefile: make dev-build
  Makefile->>Cargo: cargo --config DEV_FAST_CONFIG build
  Cargo->>dev_fast_config_toml: load config.toml
  Cargo->>NightlyToolchain: use codegen-backend cranelift
  Cargo->>MoldLinker: use -Clink-arg=-fuse-ld=mold [linux]

  Developer->>Makefile: make dev-test
  Makefile->>Cargo: cargo --config DEV_FAST_CONFIG test
  Cargo->>dev_fast_config_toml: load config.toml
  Cargo->>NightlyToolchain: use codegen-backend cranelift
  Cargo->>MoldLinker: use -Clink-arg=-fuse-ld=mold [linux]
Loading

File-Level Changes

Change Details Files
Introduce opt-in accelerated debug build targets wired to a separate Cargo config fragment.
  • Add DEV_FAST_CONFIG variable defaulting to tools/dev-fast/config.toml.
  • Define dev-build and dev-test phony targets that invoke cargo with the explicit --config fragment.
  • Document that these targets are for Cranelift+mold accelerated debug builds and require nightly.
Makefile
Document the dev-fast build flow and its constraints for contributors.
  • Add a "Fast development builds" section describing make dev-build and make dev-test.
  • Explain the use of the Cranelift backend and mold linker via tools/dev-fast/config.toml.
  • Clarify that the fragment must not be copied into .cargo/config.toml because it should remain opt-in and leave CI/release builds unaffected.
AGENTS.md
Align Dependabot coverage with the canonical configuration, adding rust-toolchain support.
  • Add a rust-toolchain update stanza with dependencies and rust-toolchain labels.
  • Configure the rust-toolchain updates to run weekly from the repository root directory.
  • Maintain existing cargo ecosystem configuration consistent with the baseline.
.github/dependabot.yml
Add the canonical dev-fast Cargo configuration fragment for local debug builds.
  • Create tools/dev-fast/config.toml with an [unstable] section enabling codegen-backend.
  • Configure [profile.dev] to use the Cranelift codegen-backend to speed debug builds.
  • Add a Linux-only target table that sets rustflags to use the mold linker, with comments about interaction with existing rustflags and why this remains outside .cargo/config.toml.
tools/dev-fast/config.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

leynos added 2 commits August 13, 2026 23:38
Estate review flagged two defects in the fragment's deployed
comments: a stale "copy this fragment" instruction that reads as
nonsense once the file is in place, and a mis-statement of Cargo's
rustflags semantics (Cargo joins the entries of every matching
`[target.*]` table; only the joined result takes precedence over
`[build].rustflags` rather than merging). Both are corrected in the
canonical source; take its bytes verbatim. No configuration key
changes.
Estate review flagged that the appended dev-build and dev-test
recipes hard-code `cargo` although the Makefile exposes an injectable
`CARGO` variable, hiding the process dependency at the command
boundary. Route both recipes through `$(CARGO)`, mirroring the
companion branch byte-for-byte so the two open pull requests merge
cleanly in either order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant