Skip to content

Update setup-rust consumers for Node.js 24 (#81) - #82

Draft
lodyai[bot] wants to merge 2 commits into
mainfrom
issue-81-update-setup-rust-action-dependencies-to-remove-node-js-20-deprecation-warnings
Draft

Update setup-rust consumers for Node.js 24 (#81)#82
lodyai[bot] wants to merge 2 commits into
mainfrom
issue-81-update-setup-rust-action-dependencies-to-remove-node-js-20-deprecation-warnings

Conversation

@lodyai

@lodyai lodyai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This branch pins every root and generated-template leynos/shared-actions
consumer to commit
80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
That shared-actions commit upgrades every direct Node.js 20 dependency in
setup-rust to a verified full commit SHA for a Node.js 24 release, removing
GitHub's temporary compatibility fallback without changing the action
interface or cache behaviour.

Closes #81.

The shared-actions branch is published, but the current GitHub integration
cannot open its prerequisite pull request (Resource not accessible by integration). This consumer pull request therefore remains a draft until a
maintainer lands the shared-actions commit on main.

Review walkthrough

Validation

  • make check-fmt: passed
  • make typecheck: passed with no issues in 30 source files
  • make lint: passed
  • make test: 89 passed, one skipped, one snapshot passed
  • make spelling: passed
  • coderabbit review --agent: passed with zero findings
  • Upstream action.yml metadata at each replacement SHA declares node24.
  • Captured shared-actions validation logs contain no Node.js 20 deprecation
    warning.

References

Summary by Sourcery

Pin all root and template GitHub workflow consumers of leynos/shared-actions to the shared commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8 so CI, coverage, audit, mutation testing, release, act validation, and Dependabot automerge use the updated Node.js 24–compatible setup-rust and related actions.

Enhancements:

  • Standardize on a single verified shared-actions revision across the repository to remove reliance on older Node.js 20-based action commits while keeping the action interfaces and caching behaviour unchanged.

CI:

  • Update all CI and auxiliary workflows (including act validation and Dependabot automerge) to reference the new shared-actions commit for setup-rust and related actions.

Tests:

  • Align generated project CI, coverage, audit, mutation testing, and release workflow templates with the same shared-actions commit to ensure consistent Node.js 24–compatible tooling across templates.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ca50cf55-8fb9-462f-aa1c-3c4de46ac1a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins all root and template GitHub Actions workflow consumers of leynos/shared-actions to a single new commit SHA that upgrades the setup-rust action (and related shared workflows) to Node.js 24 without changing their public interface or cache behavior.

File-Level Changes

Change Details Files
Update all GitHub Actions workflow references to leynos/shared-actions to the new Node.js 24-compatible commit SHA.
  • Pin setup-rust action usages in root CI and act-validation workflows to commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
  • Pin shared dependabot-automerge reusable workflow in the root workflow to commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
  • Update template CI and coverage workflows to use setup-rust and generate-coverage from commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
  • Update template CI and coverage workflows to use upload-codescene-coverage from commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8 (including commented example).
  • Pin template act-validation and audit workflows’ setup-rust usage to commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
  • Pin template mutation-testing workflow’s reusable mutation-cargo workflow to commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
  • Update the app-flavour release workflow template to use setup-rust from commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8.
.github/workflows/ci.yml
.github/workflows/act-validation.yml
.github/workflows/dependabot-automerge.yml
template/.github/workflows/ci.yml.jinja
template/.github/workflows/coverage-main.yml.jinja
template/.github/workflows/act-validation.yml
template/.github/workflows/audit.yml
template/.github/workflows/mutation-testing.yml
template/.github/workflows/{% if flavour == 'app' %}release.yml{% endif %}.jinja

Assessment against linked issues

Issue Objective Addressed Explanation
#81 Update the .github/actions/setup-rust composite action dependencies (e.g., actions/cache, mozilla-actions/sccache-action) in leynos/shared-actions to Node.js 24–compatible releases, pinned to verified full commit SHAs, so that setup-rust no longer emits Node.js 20 deprecation warnings. This PR only updates consumer workflows in leynos/agent-template-rust to pin leynos/shared-actions to commit 80c8e8b4b9e8ab223d18d2360aa1feba6c7335e8. It does not modify .github/actions/setup-rust or its internal dependencies in the leynos/shared-actions repository.
#81 Maintain the existing setup-rust action interface and cache behaviour while updating its dependencies, and update any tests, fixtures, snapshots, documentation, and dependency metadata in leynos/shared-actions that assert the old SHAs. The PR changes only consumer workflow references (root and template workflows) to point at the new shared-actions commit. It does not touch tests, fixtures, documentation, or metadata in the leynos/shared-actions repository, nor does it verify or preserve the setup-rust interface directly.
#81 Update consumer repositories to pin their leynos/shared-actions references to the new shared-actions commit SHA that contains the Node.js 24 updates for setup-rust.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

leynos and others added 2 commits August 4, 2026 02:58
Pin root and generated template workflows to the shared-actions commit
whose `setup-rust` dependencies run on Node.js 24. Align every consumer
reference on the same immutable revision so generated projects do not retain
older shared workflow or action pins.
Update the post-rebase contract metadata and its independent-action fixture
to the shared-actions descendant that retains rustflags passthrough while
updating setup-rust dependencies for Node.js 24.
@lodyai
lodyai Bot force-pushed the issue-81-update-setup-rust-action-dependencies-to-remove-node-js-20-deprecation-warnings branch from 405d12f to e6ff86c Compare August 4, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update setup-rust action dependencies to remove Node.js 20 deprecation warnings

1 participant