Repository navigation
Conversation
levb
force-pushed
the
lev-storage-rationalize
branch
3 times, most recently
from
June 1, 2026 20:23
53e81af to
042a224
Compare
Adds an orchestrator.read.* metric family with consistent attributes
(file_type/source/codec/outcome) covering each stage of a read, plus
per-layer chunker and build-file timers, so dashboards can attribute
latency end-to-end from sandbox-visible read to backend fetch.
Does not remove any of the prior metrics, this will be done separately
after the dashboards are updated.
Metrics:
- orchestrator.file.read_at build.File.ReadAt — per-fault
unit, aggregates all underlying
mappings into one record
- orchestrator.chunk.slice Chunker.Slice — per per-mapping
unit, source=mmap on cache hit
else the backend that served
- orchestrator.read.open OpenRangeReader (open / TTFB)
- orchestrator.read.read source-read wall, compressed bytes
- orchestrator.read.decompress decompress CPU + uncompressed bytes
- orchestrator.read.fetch total fetch wall + bytes delivered
- orchestrator.read.writeback NFS cache writeback wall + bytes
- orchestrator.read.pipeline.efficiency fetch / (open+read+decompress)
- orchestrator.read.cache NFS hit/miss/writeback events
- orchestrator.read.inflight concurrent fetches gauge
Spans:
- chunk.fetch runFetch goroutine span
levb
force-pushed
the
lev-gcs-read-ttfb-metric
branch
from
June 1, 2026 20:47
f75e37b to
579c5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire read-stage instrumentation across the read path with file_type/source/ codec attributes.
Metrics:
Spans: