Skip to content

CI check: raise typed exceptions from invalidArg and invalidOp - #1

Closed
leonitousconforti wants to merge 1 commit into
mainfrom
fix-invalidarg-invalidop-types
Closed

leonitousconforti wants to merge 1 commit into
mainfrom
fix-invalidarg-invalidop-types

Conversation

@leonitousconforti

Copy link
Copy Markdown
Owner

Runs Fable's CI on the fork before the upstream PR. Will be closed.

…nd invalidOp

`invalidArg` and `invalidOp` threw a plain `Exception`, so
`:? ArgumentException` and `:? InvalidOperationException` handlers never
caught them, nor the library errors raised through them. They now go
through `FSharp.Core.Operators` like `nullArg`, raising the `System`
exceptions the libraries already define. Beam tags its exception maps
inline, as it does for those exceptions' constructors.
@leonitousconforti
leonitousconforti force-pushed the fix-invalidarg-invalidop-types branch from f8aa481 to df177a6 Compare October 23, 2026 15:55
@github-actions

Copy link
Copy Markdown

Python Type Checking Results (Pyright)

Metric Value
Total errors 33
Files with errors 4
Excluded files 4
New errors ✅ No
Excluded files with errors (4 files)

These files have known type errors and are excluded from CI. Remove from pyrightconfig.ci.json as errors are fixed.

File Errors Status
temp/tests/Python/test_hash_set.py 18 Excluded
temp/tests/Python/test_applicative.py 11 Excluded
temp/tests/Python/test_nested_and_recursive_pattern.py 2 Excluded
temp/tests/Python/fable_modules/thoth_json_python/encode.py 2 Excluded

@leonitousconforti

Copy link
Copy Markdown
Owner Author

CI passed. Opened upstream as fable-compiler#5152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant