Add Docker-based CI workflow for Redis and Valkey#117
Merged
Conversation
Introduces docker-tests.yml that runs online tests against Redis 6/7 and Valkey 9 via Docker, using a matrix of image + flavor entries. Compiles with JDK 11 and passes -Dtest.flavor=valkey for Valkey jobs.
Owner
|
That file is pretty outdated now — it was written years ago before GitHub Actions and proper CI were in place, so it guided people to run tests manually. Since we have CI now (and your Docker tests), it’s no longer useful. I’ll remove it to avoid confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relevant issue: #113
Introduces
.github/workflows/docker-tests.ymlthat runs online tests against Redis and Valkey via Docker, using a matrix of image + flavor entries:redis:6redis:7redis:8.4valkey/valkey:9Each job starts two containers (port 6379 unauthenticated, port 6380 with password
test), compiles with JDK 11, and runsmvn test. Valkey jobs additionally pass-Dtest.flavor=valkey. A 10-minute job timeout is set to catch hanging tests.ETC
Just a thought—would it make sense to update the contributing.md file?