Skip to content

chore: remove redundant sepBy1 in subst parser - #15029

Open
mhuisi wants to merge 2 commits into
leanprover:masterfrom
mhuisi:push-wzntssokytqm
Open

chore: remove redundant sepBy1 in subst parser#15029
mhuisi wants to merge 2 commits into
leanprover:masterfrom
mhuisi:push-wzntssokytqm

Conversation

@mhuisi

@mhuisi mhuisi commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR removes a sepBy1 that we did not elaborate. subst chains are right-associative.

@mhuisi mhuisi added changelog-no Do not include this PR in the release changelog downstream Request a downstream-lean4 adaptation PR. labels Sep 4, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 4, 2026
@mathlib-lean-pr-testing

mathlib-lean-pr-testing Bot commented Sep 4, 2026

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2026-09-03 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2026-09-04 15:26:33)

@downstream-lean4 downstream-lean4 Bot mentioned this pull request Sep 4, 2026
Open
@leanprover-bot leanprover-bot added the breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. label Sep 4, 2026
@leanprover-bot

leanprover-bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

@mhuisi
mhuisi requested a review from Kha September 4, 2026 16:12
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Sep 4, 2026
@leanprover-bot
Update lean-toolchain for leanprover/lean4#15029
58ece72
@downstream-lean4

downstream-lean4 Bot commented Sep 4, 2026

Copy link
Copy Markdown

The adaptation PR for this PR is leanprover/downstream-lean4#47.

@leanprover-bot leanprover-bot added builds-manual CI has verified that the Lean Language Reference builds against this PR and removed breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kha Kha Awaiting requested review from Kha

Assignees

No one assigned

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR changelog-no Do not include this PR in the release changelog downstream Request a downstream-lean4 adaptation PR. toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhuisi @leanprover-bot