fix: remove lossy syntax separator array coercions - #15020
Open
mhuisi wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
|
The adaptation PR for this PR is leanprover/downstream-lean4#44. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
Array Syntax->SepArray sepandSepArray sep->Array Syntaxcoercions and adds a separator-SourceInfo-preservingTSepArray ks sep->SepArray sepcoercion instead. Fixes an issue where coercing fromTSepArray ks septoSepArray sepwould lose theSourceInfoof the separators.The former coercion is strange because an
Array Syntaxmay be either an array with separators or an array without separators, whereas the latter throws away separators.