feat: report private inherited declaration in projection notation error#13752
Open
Kha wants to merge 1 commit into
Open
feat: report private inherited declaration in projection notation error#13752Kha wants to merge 1 commit into
Kha wants to merge 1 commit into
Conversation
This PR makes projection notation errors mention a private declaration on a parent structure as the cause when applicable. Previously, the "would need to be public" hint only fired when the private declaration sat directly on the projected structure in the same module; for projections that resolved through structure inheritance, the hint was silently dropped, leaving users without the actual cause. In `resolveLValAux`, when `findMethod?` returns nothing in public scope, retry it under `withoutExporting` so the resolved private name across the structure resolution order can be used as the `declHint` for `mkUnknownIdentifierMessage`. Skip the retry in non-exporting scope, where the hint would be suppressed anyway.
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes projection notation errors always mention a private declaration on a parent structure as the cause when applicable. Previously, for projections that resolved through structure inheritance, the hint was silently omitted, leaving users without the actual cause.
In
resolveLValAux, whenfindMethod?returns nothing in public scope, retry it underwithoutExportingso the resolved private name across the structure resolution order can be used as thedeclHintformkUnknownIdentifierMessage. Skip the retry in non-exporting scope, where the hint would be suppressed anyway.