Skip to content

fix: restore subverso definition sites, unbreaking verso-slides #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kha wants to merge 1 commit into from
Closed

fix: restore subverso definition sites, unbreaking verso-slides #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion subverso/src/SubVerso/Highlighting/Code.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,12 @@ def termInfoKind
let k ← exprKind ci termInfo.lctx termInfo.stx termInfo.expr (allowUnknownTyped := allowUnknownTyped)
if (← read).definitionsPossible then
if let some (.const name sig docs _isDef pp?, prettySig) := k then
let isDef ← withEnv (constEnv ci.env (← getEnv) name) <| isDefinition name termInfo.stx
-- Unlike `constEnv`, the command's environment is preferred here: declaration ranges are
-- registered as the command finishes, so they are missing from a node's environment even
-- when it already contains the constant, and `isDefinition` would then see no definition.
let cmdEnv ← getEnv
let env := if cmdEnv.contains name then cmdEnv else ci.env
let isDef ← withEnv env <| isDefinition name termInfo.stx
return some (.const name sig docs isDef pp?, prettySig)
return k

Expand Down
Loading