Skip to content

Partial completion of #855#1203

Merged
jstoobysmith merged 3 commits into
leanprover-community:masterfrom
kastch:feat/855-time-manifold-derivatives-translations
Jun 18, 2026
Merged

Partial completion of #855#1203
jstoobysmith merged 3 commits into
leanprover-community:masterfrom
kastch:feat/855-time-manifold-derivatives-translations

Conversation

@kastch

@kastch kastch commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Addresses #855

Added Time.manifoldDeriv in SpaceAndTime/Time/Derivatives.lean: the derivative of a function from Time to a manifold, valued in the tangent space.

Added Time.manifoldDeriv_eq, Time.deriv_eq_mfderiv, Time.deriv_eq_manifoldDeriv, and Time.manifoldDeriv_const in SpaceAndTime/Time/Derivatives.lean: basic API relating manifoldDeriv to mfderiv and to the existing Time.deriv for normed-space targets.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed.
If submitting to ./Physlib or ./QuantumInfo, please
see our review guidelines
if you are not familiar with the process. You should expect a back and forth
with a reviewer before your PR is merged. See also that link for how to
add appropriate labels to your PR. The PR will also go through a number
of automated checks. You can learn more about these here,
including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process,
though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this
thread of the Lean Zulip.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment about vadd results. I will add awaiting-author label. Please can you comment with -awaiting-author when responded (helps with review organization).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear to me why these lemmas in this file are needed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstoobysmith ! Agreed - added more a draft ones rather then real closing for the second thing. I'll address it in a full API way in a separate PR later. In this one - removed those.

@jstoobysmith jstoobysmith added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 18, 2026
Comment thread Physlib/SpaceAndTime/Time/Derivatives.lean
@kastch

kastch commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 18, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - many thanks!

@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly t-space-time Space and time labels Jun 18, 2026
@jstoobysmith jstoobysmith merged commit e7aa84a into leanprover-community:master Jun 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-space-time Space and time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants