Skip to content

feat(space): add spherical cylinder surface#1199

Merged
jstoobysmith merged 2 commits into
leanprover-community:masterfrom
Robby955:physlib/spherical-cylinder-surface
Jun 18, 2026
Merged

feat(space): add spherical cylinder surface#1199
jstoobysmith merged 2 commits into
leanprover-community:masterfrom
Robby955:physlib/spherical-cylinder-surface

Conversation

@Robby955

@Robby955 Robby955 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the spherical cylinder surface API under PhyslibAlpha.SpaceAndTime.Space.Surfaces.

Changes

  • Defines the spherical cylinder embedding into Space 3 as the unit circular shell in Space 2 transported through slice 2, extruded along .
  • Adds injectivity, continuity, and measurable embedding lemmas.
  • Adds the induced surface measure, tempered-growth instance, and SFinite instance.
  • Adds the corresponding distribution and integral application lemmas.

Notes

  • This intentionally does not add IsFiniteMeasure: the cylinder is unbounded along the axis.
  • No measure-zero theorem: issue API: Spatial Surfaces #943 asks for that only where applicable, and the sibling surface files do not expose analogous null-range theorems.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed.
If submitting to ./Physlib or ./QuantumInfo, please
see our review guidelines
if you are not familiar with the process. You should expect a back and forth
with a reviewer before your PR is merged. See also that link for how to
add appropriate labels to your PR. The PR will also go through a number
of automated checks. You can learn more about these here,
including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process,
though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this
thread of the Lean Zulip.

@Robby955 Robby955 marked this pull request as ready for review June 17, 2026 21:31
@jstoobysmith jstoobysmith self-assigned this Jun 18, 2026
@jstoobysmith jstoobysmith added the PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. label Jun 18, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Jun 18, 2026
@jstoobysmith jstoobysmith merged commit 36cd0fc into leanprover-community:master Jun 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants