Skip to content

feat: add solid sphere surface#1198

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
Robby955:add-solid-sphere-surface
Jun 18, 2026
Merged

feat: add solid sphere surface#1198
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
Robby955:add-solid-sphere-surface

Conversation

@Robby955

Copy link
Copy Markdown
Contributor

Adds the solid sphere (closed unit ball) to the spatial surfaces API in PhyslibAlpha, following the merged Line.lean: the embedding into Space d.succ, the associated measure (ambient volume restricted to the closed unit ball), the temperate-growth instance, and the distribution. A solid region has positive ambient volume, so the measure-zero requirement does not apply and is replaced by a positive-volume statement. Part of #943.

Add the solid sphere (closed unit ball) to the spatial surfaces API:
the embedding into Space d.succ, the associated measure (ambient volume
restricted to the closed unit ball), the temperate-growth instance, and
the distribution. As the solid sphere has positive ambient volume, the
measure-zero requirement does not apply and is replaced by a positive
ambient volume statement. Part of leanprover-community#943.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed.
If submitting to ./Physlib or ./QuantumInfo, please
see our review guidelines
if you are not familiar with the process. You should expect a back and forth
with a reviewer before your PR is merged. See also that link for how to
add appropriate labels to your PR. The PR will also go through a number
of automated checks. You can learn more about these here,
including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process,
though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this
thread of the Lean Zulip.

@jstoobysmith jstoobysmith added the PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. label Jun 18, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approved. Will merge shortly.

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Jun 18, 2026
jstoobysmith

This comment was marked as duplicate.

@jstoobysmith jstoobysmith merged commit 1ffc8b9 into leanprover-community:master Jun 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants