Skip to content

feat: Stinespring dilation#1191

Open
bjoernkjoshanssen wants to merge 4 commits into
leanprover-community:masterfrom
bjoernkjoshanssen:master
Open

feat: Stinespring dilation#1191
bjoernkjoshanssen wants to merge 4 commits into
leanprover-community:masterfrom
bjoernkjoshanssen:master

Conversation

@bjoernkjoshanssen

Copy link
Copy Markdown
Contributor

Stinespring dilation theorem, finite-dimensional version.
One of the Top 100 Quantum Theorems from https://marcodavid.net/top100/

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed.
If submitting to ./Physlib or ./QuantumInfo, please
see our review guidelines
if you are not familiar with the process. You should expect a back and forth
with a reviewer before your PR is merged. See also that link for how to
add appropriate labels to your PR. The PR will also go through a number
of automated checks. You can learn more about these here,
including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process,
though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this
thread of the Lean Zulip.

@jstoobysmith

Copy link
Copy Markdown
Member

This is my fault, but one of the linters for PhyslibAlpha is broken - meaning it is not properly checking whether or not the file is correctly imported into ./PhyslibAlpha.lean. I've prepared a fix at #1193. But in the meantime - please can add

public import  PhyslibAlpha.QuantumMechanics.StinespringDilation

to ./PhyslibAlpha.lean. This will end up triggering a bunch of other linters; primarily that a lot of your definitions don't have doc-strings.

@bjoernkjoshanssen

bjoernkjoshanssen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

This is my fault, but one of the linters for PhyslibAlpha is broken - meaning it is not properly checking whether or not the file is correctly imported into ./PhyslibAlpha.lean. I've prepared a fix at #1193. But in the meantime - please can add

public import  PhyslibAlpha.QuantumMechanics.StinespringDilation

to ./PhyslibAlpha.lean. This will end up triggering a bunch of other linters; primarily that a lot of your definitions don't have doc-strings.

Sounds good, trying that! But I can't find a linter that picks up on the missing doc-strings, runPhyslibAlphaLinters has no comment about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants