Definition of HilbertSpace#1184
Conversation
…hain/Basic.lean to be compatible with the new definition.
|
Thank you for this PR, which will now be reviewed. Please If you want to bring attention to this PR, please write a message on this |
| /-- The finite dimensional Hilbert space of dimension `n`. -/ | ||
| def FiniteHilbertSpace (n : ℕ) : Type := EuclideanSpace ℂ (Fin n) | ||
| -- def FiniteHilbertSpace (n : ℕ) : Type := EuclideanSpace ℂ (Fin n) | ||
|
|
There was a problem hiding this comment.
For reference, I kept the old definition here as comments
|
This looks like a great first PR. Only one comment from me which is: Feel free to remove the old stuff - it is saved in the git history, so we can always retrieve it if need be. I've added an awaiting-author label, when this is done could you comment with a comment that says |
|
Ok thanks for the feedback! I removed the commented code |
|
-awaiting-author |
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved! Will merge shortly
Hello,
I'm a new contributor to lean and saw the project on UnitaryHack, I didnt see explicit projects there so I looked over existing issues and decided to work on the definition of
HilbertSpaceto start. This PR makes progress towards the issueI have tried to follow the TODO instructions in
QuantumMechanics\HilbertSpace.lean.Summary of changes
FiniteHilbertSpacestructure asEuclideanSpacecarrying avaletnry as suggested in the TODO.equivEuclideanto transferAddCommGroupandModuleproperties for a vector space.QuantumInfo/Finite/Braket.lean.(H : Type*) [NormedAddCommGroup H] [InnerProductSpace ℂ H] [CompleteSpace H] [FiniteDimensional ℂ H]linearEquivEuclideandefinition transfersNormedAddCommGroup,InnerProductSpace,CompleteSpaceandFiniteDimensional.TightBindingChain/Basic.lean, we also definebasisFun.AI usage
As a beginner in writing lean code, I have used claude code and instructed the writing to be as close to mathlib quality. I have interacted with the AI for multiple sessions and have read all the lines of the code and tried to have a high level understanding as mentioned above. However, I realize I probably am not able to fully understand the nuance of design decisions and would very much appreciate your feedback on these.
The modfied files compile in lean, my linter passed 1/7 but is currently taking a very long time on step 2, if its ok I can come back to the linter.
Additionallz I have followed the review guidelines but could have missed something. Look forward to your feedback.