[Merged by Bors] - fix: correct deprecation for orthogonalProjection_mem_subspace_orthogonalComplement_eq_zero

[grunweg]

#38970 tried to create one, but made a slip (and created a deprecated alias for a declaration that never existed). Correct this oversight. Noticed during leanprover-community/sphere-eversion#143.

---

[github-actions]

PR summary 4dddbc9d3d

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff (regex)

- orthogonalProjection_apply_of_mem_orthogonal

You can run this locally as follows

## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 4dddbc9).

• +1 new declarations
• −1 removed declarations

-Submodule.orthogonalProjection_apply_of_mem_orthogonal
+Submodule.orthogonalProjection_mem_subspace_orthogonalComplement_eq_zero

---

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4dddbc9d3d
Reference commit e24b844979

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[themathqueen]

Good catch! I guess I need to be extra careful when renaming and deprecating at the same time.

maintainer merge

[github-actions]

🚀 Pull request has been placed on the maintainer queue by themathqueen.

[j-loreaux]

bors merge

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• ci (staging) / Post-CI job
• ci (staging) / Build
• ci (staging) / Lint style
• ci (staging) / Post-Build Step
• ci (staging) / Test and lint