Repository navigation
Conversation
… it when flipped Firefox ignores `backface-visibility: hidden` on the z-indexed CardFront because it has no transform of its own, so after the flip the front face is painted mirrored over CardBack. Give CardFront `rotateY(0deg)` when the card flips, matching the existing FrontFace pattern in the same file. Refs meshery/meshery#22640 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gaurrov <gsn2k7@gmail.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Front-face transform and tests src/custom/CustomCatalog/style.tsx, src/__testing__/CustomCatalogCard.test.tsx |
CardFront sets a zero-degree Y-axis transform when shouldFlip is true. Tests check the front face’s backface visibility and transform with flipping enabled, and its empty transform with flipping disabled. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: fitzergerald
Merge Risk: 
Minimal · up to 66bf8
-
No actionable merge-blocking risk remains after removing the unsupported visual-regression request.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Notes for Reviewers
This PR addresses meshery/meshery#22640. In the Kanvas "Start with a Template" dialog, hovering a catalog card in Firefox shows the front face mirrored on top of the back face.
Root cause
CardFrontisposition: absolute; z-index: 1withbackface-visibility: hidden, but it has notransformof its own. Firefox does not applybackface-visibilityto that face once.innerCardrotates. Because of thez-index, it also paints the face aboveCardBack, so the front shows through mirrored. Chromium hides it correctly, so the bug only appears in Firefox.Fix
When the card flips (
shouldFlip),CardFrontnow getstransform: 'rotateY(0deg)'. This is the same patternFrontFacealready uses in this file. Cards that don't flip are unchanged.Screenshots
The real
CustomCatalogCard, rendered on its own from Sistent source and hovered (Firefox 132 / Chrome 155):Before, Firefox: front face mirrored over the back face
After, Firefox: back face renders clean
After, Chrome: unchanged (Chrome was never affected)
How it was verified
CardFrontits own transform fixes the problem. Removing just thez-indexstill lets thez-indexed "type" chip and ribbon show through mirrored. Removing the title line-clamp, the ribbon, the border,transition: allor the outerpreserve-3dhad no effect.CustomCatalogCardand hovered it in Firefox and Chrome, before and after the change. The front is mirrored before the fix; after it, the back face is clean in both browsers, and the card looks the same when not flipped.src/__testing__/CustomCatalogCard.test.tsxchecks that the front face of a flipping card has the transform and that a non-flipping card doesn't. It fails without the fix and passes with it.jest(656 passed),eslint,prettierandtsupbuild all pass.Kanvas will need a Sistent version bump to pick this up.
Signed commits
Summary by CodeRabbit
Bug Fixes
Tests