You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug] sanitizeCatalogImageUrl is missing from the published declaration bundle #1851
TS2305: Module '"@sistent/sistent"' has no exported member 'sanitizeCatalogImageUrl'.
This was previously addressed in #1697. The explicit root export was added in 8567da11, but was discarded by the sync merge b7d22bbc before the PR was merged.
The leaf module and the exports through Helper.ts and src/custom/index.tsx are still present. The explicit export from src/index.tsx is not.
Expected Behavior
sanitizeCatalogImageUrl should be available from the package root in both the runtime bundle and the generated TypeScript declarations.
Screenshots/Logs
Published 0.22.6 package:
npm pack @sistent/sistent@0.22.6
tar -xzOf sistent-sistent-0.22.6.tgz package/dist/index.d.ts | grep sanitizeCatalogImageUrl
# no result
tar -xzOf sistent-sistent-0.22.6.tgz package/dist/index.js | grep sanitizeCatalogImageUrl
# symbol is present
The export is present before the sync merge and absent afterward:
git show 8567da11:src/index.tsx | grep -c sanitizeCatalogImageUrl
# 3
git show 'b7d22bbc^1:src/index.tsx'| grep -c sanitizeCatalogImageUrl
# 3
git show 'b7d22bbc^2:src/index.tsx'| grep -c sanitizeCatalogImageUrl
# 0
git show b7d22bbc:src/index.tsx | grep -c sanitizeCatalogImageUrl
# 0
Activity
fix(CustomCatalog): re-export sanitizeCatalogImageUrl from the packag…
test(CustomCatalog): guard sanitizeCatalogImageUrl in the declaration…
test(CustomCatalog): guard the root re-export of sanitizeCatalogImageUrl