fix: use positional params only in hextra jupyter shortcode example#124
Merged
saurabhraghuvanshii merged 1 commit intolayer5io:masterfrom Apr 8, 2026
Conversation
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
Oluwatunmise-olat
changed the title
Oluwatunmise-olat
requested review from
Rajesh-Nagarajan-11 and
saurabhraghuvanshii
saurabhraghuvanshii
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes: The Hugo build was failing because of an invalid shortcode call in (
content/content-formatting-examples/hextra/jupyter/index.md)I traced the failing GitHub Action to one shortcode call in the Jupyter formatting example page:
content/content-formatting-examples/hextra/jupyter/index.md.The example was mixing positional and named shortcode parameters, which Hugo rejects:
got named parameter 'filename'. Cannot mix named and positional parameters.I changed that example to use positional parameters only.
Change made
{{% hextra/jupyter "example-notebook.ipynb" filename="analysis.ipynb" %}}{{% hextra/jupyter "example-notebook.ipynb" %}}Signed commits