Repository navigation
feat(snippets): add flag override snippets for the Ruby SDK - #720
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Generated-by: termag
Member
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2fee6bc. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileData.override_sourcepassed toDataSystem.default.overrides, the source options (two files,:ignoreduplicate key handling, and watching), and a check ofreason.override_affected.Config.newreads the data system fromdata_system_config:and needs the built configuration, so the snippets callbuildand pass it under that key.ruby-syntax-onlyscaffold only parses, so validation passes now. Do not release these snippets until the SDK release with flag overrides ships.listen3.10.1 and the shared override file examples in JSON and YAML; every flag evaluated to the documented value and reason kind.Opened from termag
Note
Overview
Adds three reference snippets for the upcoming Ruby server SDK “Flag overrides” docs, wired to
ruby-syntax-onlyvalidation.They show wiring
FileData.override_sourceintoDataSystem.default.overrides(...).buildviadata_system_config:onLaunchDarkly::Config, including a basic single-file +LDClientexample, an advanced variant with multiple paths,:ignoreduplicate keys, and:watchingchange detection, and checkingdetail.reason.override_affectedaftervariation_detail.These examples target APIs from the in-flight Ruby SDK override work and should stay unpublished until that SDK release ships.
Reviewed by Cursor Bugbot for commit 2fee6bc. Bugbot is set up for automated code reviews on this repo. Configure here.