Repository navigation
feat!: Remove payload filter support from the FDv2 data system - #485
Merged
Merged
Conversation
The FDv2 streaming and polling requests, and the FDv1 fallback polling request, no longer send the filter query parameter. FDv2 already logged that payload filtering was unsupported and that the payload_filter_key option had no effect, but the requests still sent it. The behavior now matches the warning. The FDv1 data system keeps its payload filter support until the FDv1 removal deletes it. The contract tests no longer map the payloadFilter data system setting. The filtering capabilities stay, because only harness v2 tests them, against FDv1.
keelerm84
marked this pull request as ready for review
November 5, 2026 14:56
kinyoklion
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FDv2 streaming and polling requests, and the FDv1 fallback polling
request, no longer send the filter query parameter. FDv2 already logged
that payload filtering was unsupported and that the payload_filter_key
option had no effect, but the requests still sent it. The behavior now
matches the warning.
The FDv1 data system keeps its payload filter support until the FDv1
removal deletes it. The contract tests no longer map the payloadFilter
data system setting. The filtering capabilities stay, because only
harness v2 tests them, against FDv1.