Repository navigation
test(AIC-3601): use the new handoff result text in the langchain-agents fixture - #233
Merged
Merged
Conversation
…ts fixture The fixture only checks that a handoff handler's return value passes through the built tool unchanged, so it still passed with the old wording. Match the text TESTING.md §3.15a now pins so it no longer reads as current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XieX
enabled auto-merge (squash)
October 28, 2026 14:49
jeffdupont
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review follow-up from #230.
test_handoff_handler_records_destinationinpackages/langchain-agents/tests/test_handler.pydefines its own handoff handler and still returned the old result text (Finish your own work and provide your final response.). It now returns the text #230 puts ingraph.pyand thatTESTING.md§3.15a pins:Handoff to billing recorded. billing takes over when your turn ends. Finish your own part, then end your turn. Do not answer for billing.The fixture only checks that a handler's return value passes through the built tool unchanged, so the test was never wrong, only out of date. This is a separate
test:PR so that langchain-agents doesn't get a release for a test-only change. Squash-merging it into #230 would have put it under that PR'sfix:title.The PRs can merge in either order. Neither depends on the other.
Tests
langchain-agents suite: 222 passed.
ruff checkandruff format --checkare clean.🤖 Generated with Claude Code
Note
Overview
Updates
test_handoff_handler_records_destinationso the local mock handoff handler and its expected tool return value use the newer handoff guidance string (billing takes over when the turn ends; finish your part and do not answer for the destination agent), matching whatgraph.pyand TESTING.md §3.15a specify after the related production change.No runtime or handler logic changes—only test expectations so the fixture stays in sync with the canonical handoff copy.
Reviewed by Cursor Bugbot for commit a0f7e50. Bugbot is set up for automated code reviews on this repo. Configure here.