Repository navigation
testing(evaluations): update failing public surface test - #168
Merged
Merged
Conversation
jeffdupont
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow up PR; recently merged PR #157 migrated evaluations from code to the experimental namespace. In doing so I added in a test for public surface, but in the time between writing the test and merging to main the surface changed and the test consequently fails. Updating expected set to keep the test accurate.
Note
Overview
Updates the checked-in
ROOT_SURFACEsnapshot intest_public_surface.pyso it matches the currentlaunchdarkly_ai_server.__all__after evaluations moved to the experimental namespace.Removes
set_openllmetry_completionandset_openllmetry_promptfrom the expected root export set—those names are no longer on the package root public API, so the test stops failing on a stale allowlist.Reviewed by Cursor Bugbot for commit 4d407bd. Bugbot is set up for automated code reviews on this repo. Configure here.