Repository navigation
fix: major bumps for toml, basic-ftp, firebase-admin, NestJS 11, fsspec and x/crypto security advisories - #834
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…sspec security advisories Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
…-batch/2026-10-19
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
| linkType: hard | ||
|
|
||
| "markdown-it@npm:12.3.2, markdown-it@npm:^12.3.2": | ||
| "markdown-it@npm:12.3.2": |
There was a problem hiding this comment.
High severity vulnerability may affect your project—review required:
Line 34792 lists a dependency (markdown-it) with a known High severity vulnerability.
ℹ️ Why this matters
Affected versions of markdown-it are vulnerable to Inefficient Algorithmic Complexity / Uncontrolled Resource Consumption. markdown-it is vulnerable to Denial of Service when the typographer option is enabled: the smartquotes rule has quadratic complexity on input with many opening quotes followed by unmatched closing quotes of the other kind, so rendering crafted Markdown can exhaust CPU.
References: https://euvd.enisa.europa.eu/vulnerability/EUVD-2026-104538, GHSA, CVE
To resolve this comment:
Check if you run markdown-it with -t or --typographer flag via the CLI.
- If you're affected, upgrade this dependency to at least version 14.3.2 at yarn.lock.
- If you're not affected, comment
/fp we don't use this [condition]
💬 Ignore this finding
To ignore this, reply with:
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
You can view more details on this finding in the Semgrep AppSec Platform here.
There was a problem hiding this comment.
Tracked, not fixed in this update: the markdown-it 14.3.2 → 14.3.3 advisories (GHSA-gfr2-rv44-r23c / GHSA-vfgh-jcmw-g37q) were first reported on 2026-10-20, so they are inside the 7-day hold for this 2026-10-26 run and will be picked up next run. The 12.3.2 copy comes from markdownlint ~0.25 (dev tooling) and needs a parent major upgrade, so it is listed under deferred findings in the PR description.
Dependency vulnerability fixes (automated)
Generated by the Devin Dependency Security Vuln Fix automation run on 2026-10-26; continues the 2026-10-19 update on this branch.
Change type: Major version bump(s), manifest/lockfile only.
Warning
We're not just looking for a review like a normal PR. Security can offer this fix as a recommendation, but doesn't have the tooling or domain knowledge to safely verify changes like this end-to-end for each repo. Please review, test, and own deployment before merging. For more information: https://launchdarkly.atlassian.net/wiki/spaces/SEC/pages/5360943572/Dependency-Vulnerability-Remediation-with-Devin.
Findings addressed
resolutions"toml@^3.0.0": "^4.2.0"; parentremark-mdx-frontmatter1.1.1 via@remix-run/dev)"basic-ftp"raised^5.3.1→^6.2.1; parentget-uri6.0.1 in the puppeteer proxy chain)firebase-admin^11.5.0→^12.7.0andfirebase-functions-test^3.0.0→^3.2.0ine2e/functions)e2e/nestjs:@nestjs/common/core→^11.1.18,platform-express→^11.1.18,axios→^4.0.1,cli→^11.0.0,schedule→^5.0.1,schematics→^11.0.0,swagger→^11.0.0; root resolution@nestjs/common→^11.1.18;sdk/highlight-nestdevDependency@nestjs/common→^11.1.18, its peer range@nestjs/core >=10is unchanged)@nestjs/common10 → 11, above)huggingface-hub>=2023.5.0,poetry update fsspec --lockwith Poetry 2.2.1)e2e/python-plugin-flask)poetry update fsspec --lockwith Poetry 2.3.4, matching the lock header)e2e/go,e2e/go-plugin,sdk/highlight-go)go get golang.org/x/crypto@v0.55.0 && go mod tidy, drags x/net 0.57.0, x/sys 0.47.0, x/text 0.41.0, x/sync 0.22.0;godirective stays 1.25.0)No application or SDK source files are changed.
sdk/highlight-nest(published as@highlight-run/nest) only has a devDependency change, so its runtime/peer contract is unchanged. All new lock entries are ≥7 days old (reponpmMinimalAgeGate: 7dhonoured, no override).Deferred / excluded findings
Minor/patch fixes from this run are in the existing security PR #757.
@angular/cli19.2.x; needs thee2e/angularAngular 19 → 20 migration (owner-led).metroandlessdeclare^1(root ande2e/react-native). Upstream-blocked.@graphql-codegen/cli7 / codegen stack upgrade that regenerates SDK GraphQL types; owner-led.go/andsdk/highlight-go.@opentelemetry/instrumentation/sdk-node0.203 → 0.22x, OTel JS 1.x → 2.x); owner-led.^2.0.1) or live in therrwebsubmodule.~> 1.4; Ruby 3.3.4 images can't be pulled on this machine to verify.go 1.26directive in the published Go modules; owner decision.Verification
Re-run on 2026-10-26 after merging
main(clean merge) and adding the x/crypto and Flask fsspec rows:go build ./...+go vet ./...ine2e/go-pluginandsdk/highlight-go;e2e/gohas twomainpackages in one directory (echo.go/fiber.go), sogo build ./...fails identically onmain(pre-existing). ✅go test ./...insdk/highlight-goexceptlog.TestParseConsoleMessages, which fails identically onmain(pre-existing).poetry update fsspec --lock(Poetry 2.3.4) — onlyfsspecmoved.pretty-quick --stagedran on the commit.Re-run on 2026-10-19:
PUPPETEER_SKIP_DOWNLOAD=1 YARN_NPM_REGISTRY_SERVER=https://registry.npmjs.org node .yarn/releases/yarn-4.13.0.cjs install --mode=skip-build; ✅yarn dedupe --check.yarn turbo run build --filter @highlight-run/nest --filter nestjs --filter functions(17/17), plusremix#buildinside the test run below.yarn test --continue --filter='!aws-lambda'(79/79 after generating the Prisma client fore2e-express-ts, which--mode=skip-buildskips;aws-lambda#buildneeds the AWSsamCLI, not installed here).yarn test, incl.nestjs#lint); Huskypretty-quick --stagedran on the commit.Reviewer focus:
e2e/nestjs(NestJS 11 example) ande2e/functions(firebase-admin 12) are example apps — please smoke-test them; the toml/basic-ftp overrides affect only dev tooling (Remix MDX frontmatter, puppeteer proxy agent).Note
Overview
Manifest-only security remediation that bumps several high/medium advisory packages via direct dependencies, Yarn resolutions, and Poetry lock updates—no application or SDK source changes.
Root Yarn resolutions add
toml@^3.0.0→^4.2.0(Remix MDX tooling) and raisebasic-ftpto^6.2.1(puppeteer proxy chain), plus align@nestjs/commonto^11.1.18workspace-wide.The
e2e/nestjsexample moves the Nest stack to v11 (common/core/platform-express,@nestjs/axios4,cli/schematics11,schedule5,swagger11).sdk/highlight-nestonly updates the devDependency on@nestjs/common; published peer range (@nestjs/core >=10) is unchanged.e2e/functionsupgradesfirebase-adminto^12.7.0andfirebase-functions-testto^3.2.0(addresses vulnerable@fastify/busboytransitives).sdk/@launchdarkly/observability-pythonlockfile bumpsfsspecto2026.9.0.Reviewer focus: smoke-test
e2e/nestjsande2e/functions; transitive tooling (toml,basic-ftp) affects dev/build paths only.Reviewed by Cursor Bugbot for commit c903924. Bugbot is set up for automated code reviews on this repo. Configure here.