chore: bump CI LuaRocks pin to 3.13.0 - #127
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
None — routine dependency audit of this repo and its examples.
Describe the solution you've provided
Bumps the exact LuaRocks pin used by CI and the
install-lua-sdkworkflow from3.12.0to3.13.0(latest LuaRocks release, published 2026-01-28). No shipped code or documented minimums change.Audit result for the LaunchDarkly dependencies — no change needed:
.github/variables/cpp-sdk-versions.env, example Dockerfiles)README "Minimum Version" entries (3.9.0 / 2.1.19) are deliberately left alone — the newer SDK works but is not required.
No deprecated LaunchDarkly C-binding APIs are used by
launchdarkly-server-sdk.c/launchdarkly-server-sdk-redis.c; both compile warning-free against C++ server SDK 3.13.1.Describe alternatives you've considered
Leaving the pin at 3.12.0 (it works); bumping the
hello-nginxOpenResty base image (1.21.4.1-0-jammy, quite old) — left out as it is unrelated to this audit and higher risk.Additional context
Validated locally on Ubuntu 22.04 / Lua 5.3, prebuilt C++ server SDK + Redis Source 2.4.1 dynamic Linux artifacts, Boost 1.81.0:
luarocks 3.13.0built both rockspecs (launchdarkly-server-sdk,launchdarkly-server-sdk-redis) successfully.luarocks test launchdarkly-server-sdk-2.2.0-0.rockspec→Ran 20 tests ... 20 successes, 0 failures(same result with 3.12-era luarocks and with 3.13.0).hello-lua-serverexample against a real environment SDK key: it initialized, connected, and printedThe sample-feature feature flag evaluates to false.(flag absent in that project, so the default was returned).Link to Devin session: https://app.devin.ai/sessions/f15a4832f3d24aefaadc15789ad9d241