Skip to content

docs(AIC-3692): say which project id attribute the telemetry resource carries - #185

Merged
jeffdupont merged 4 commits into
mainfrom
jdupont/aic-3692-project-id-note
Oct 28, 2026
Merged

jeffdupont merged 4 commits into
mainfrom
jdupont/aic-3692-project-id-note

Conversation

@jeffdupont

@jeffdupont jeffdupont commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What

Part of AIC-3692. #176 renamed the telemetry resource's project id attribute from highlight.project_id to launchdarkly.project_id, but the docs never named either one. The client README and agents.md listed service.name and deployment.environment as what initClient() sets, and stopped there.

The README note and the agents.md bullet say initClient() sets launchdarkly.project_id to the resolved SDK key, not the project's ID. Neither mentions highlight.project_id: no customer-facing doc ever named it, and the changelog's breaking-change entry from #176 covers the rename.

Docs only: packages/client/README.md and packages/client/agents.md. No code, API report or link changes. The Python SDK gets the same note in launchdarkly/python-ai-sdk#239.

Checks

🤖 Generated with Claude Code


Note

Overview
Documents what initClient() already puts on the OTel resource after the rename from highlight.project_id to launchdarkly.project_id.

packages/client/README.md and agents.md now state that launchdarkly.project_id is set to the resolved SDK key, not the LaunchDarkly project ID, and that this attribute is not configurable via env or options (unlike service.name and deployment.environment). No runtime or API changes.

Reviewed by Cursor Bugbot for commit f84b945. Bugbot is set up for automated code reviews on this repo. Configure here.

jeffdupont and others added 4 commits October 28, 2026 11:01
… carries

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… note

The README never named highlight.project_id, so the note only needs the current attribute. The changelog breaking-change entry from #176 covers the rename.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jeffdupont
jeffdupont merged commit 6945ed6 into main Oct 28, 2026
20 of 21 checks passed
@jeffdupont
jeffdupont deleted the jdupont/aic-3692-project-id-note branch October 28, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants