Skip to content

chore: Fix segment key in FileData example (includes → included)#189

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783717817-filedata-included
Open

chore: Fix segment key in FileData example (includes → included)#189
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783717817-filedata-included

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

What: The JSON segment example in the file data source Javadoc (FileData.java) used "includes" for segment members. Changed it to "included".

Why: The canonical segment field is "included" (with "excluded"). The parser reads included, so an includes key is silently dropped and copy-pasting the example doesn't actually add members to the segment.

Change:

 "segments": {
   "segment-key-1": {
     "key": "segment-key-1",
-    "includes": [ "user-key-1" ]
+    "included": [ "user-key-1" ]
   }
 }

Docs-only comment fix. No code, CHANGELOG, or version changes. Mirrors ruby-server-sdk#406 and sdk-meta#541.

Link to Devin session: https://app.devin.ai/sessions/741446729be24f46bb034334384575c7
Requested by: @jsonbailey


Note

Low Risk
Comment-only Javadoc change with no runtime, API, or behavioral impact.

Overview
Corrects the file data source Javadoc sample in FileData.java so segment membership uses included instead of includes, matching what the file parser and LaunchDarkly segment JSON actually expect.

Copy-pasting the old example would leave segment members ignored because includes is not a recognized field; the doc now aligns with included / excluded usage elsewhere in the SDK.

Reviewed by Cursor Bugbot for commit c018032. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@jsonbailey jsonbailey marked this pull request as ready for review July 10, 2026 21:13
@jsonbailey jsonbailey requested a review from a team as a code owner July 10, 2026 21:13
@devin-ai-integration devin-ai-integration Bot changed the title docs: Fix segment key in FileData example (includes → included) chore: Fix segment key in FileData example (includes → included) Jul 10, 2026
@jsonbailey jsonbailey requested a review from tanderson-ld July 10, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant