chore: Fix segment key in FileData example (includes → included)#189
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore: Fix segment key in FileData example (includes → included)#189devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jsonbailey
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What: The JSON segment example in the file data source Javadoc (
FileData.java) used"includes"for segment members. Changed it to"included".Why: The canonical segment field is
"included"(with"excluded"). The parser readsincluded, so anincludeskey is silently dropped and copy-pasting the example doesn't actually add members to the segment.Change:
"segments": { "segment-key-1": { "key": "segment-key-1", - "includes": [ "user-key-1" ] + "included": [ "user-key-1" ] } }Docs-only comment fix. No code, CHANGELOG, or version changes. Mirrors ruby-server-sdk#406 and sdk-meta#541.
Link to Devin session: https://app.devin.ai/sessions/741446729be24f46bb034334384575c7
Requested by: @jsonbailey
Note
Low Risk
Comment-only Javadoc change with no runtime, API, or behavioral impact.
Overview
Corrects the file data source Javadoc sample in
FileData.javaso segment membership usesincludedinstead ofincludes, matching what the file parser and LaunchDarkly segment JSON actually expect.Copy-pasting the old example would leave segment members ignored because
includesis not a recognized field; the doc now aligns withincluded/excludedusage elsewhere in the SDK.Reviewed by Cursor Bugbot for commit c018032. Bugbot is set up for automated code reviews on this repo. Configure here.