This repository was archived by the owner on Nov 2, 2026. It is now read-only.
Repository navigation
chore: correct commented default class name to AICompletionConfigDefault - #38
Merged
Merged
Conversation
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
approved these changes
Aug 10, 2026
keelerm84
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The four
getting_startedcompletion examples show a commented-out resiliency default that referencesAIConfig, a class that no longer exists inlaunchdarkly-server-sdk-ai1.x. Anyone uncommenting it hitsImportError/NameError. The current name isAICompletionConfigDefault, whichfeatures/create_modelalready uses.No dependency changes: every manifest uses floor/caret constraints and
poetry.lockis gitignored, sopoetry installalready resolves to the latest within-major versions (launchdarkly-server-sdk-ai1.2.0,launchdarkly-observability1.3.1,launchdarkly-server-sdk-ai-langchain0.8.0,langchain1.3.14).google-genaistays on^1.30.0since 2.x would be a major jump.How it was tested
poetry installin all 10 example directories against latest published deps, then imported each example module — all succeed (the OpenAI example instantiatesOpenAI()at import time, so it needsOPENAI_API_KEY, which is unrelated to this change).AICompletionConfigDefaultdefault and an Anthropic model, confirming the corrected class name works and metrics are tracked:Limitations
sample-completion,sample-agent,sample-judge, ...) exist in the hello-app LaunchDarkly project (FLAG_NOT_FOUND), and provider keys for OpenAI/Gemini/Bedrock are not available here. The end-to-end run above used a local default plus an Anthropic key instead.launchdarkly-observability's generated GraphQL client imports the deprecatedwebsockets.clientAPI, emittingDeprecationWarningon import. That belongs to the observability SDK.Link to Devin session: https://app.devin.ai/sessions/d518388a79344d6ebcdaaeedbef361d0
Requested by: @jsonbailey
Note
Overview
Updates the commented resiliency default in four
getting_startedcompletion samples (Bedrock, Gemini, LangChain, OpenAI) so it referencesAICompletionConfigDefaultinstead of the removedAIConfigtype fromlaunchdarkly-server-sdk-ai1.x.Only documentation-style comments change; live
completion_configcalls are untouched. Copying the example default no longer fails at import withNameError/ImportError.Reviewed by Cursor Bugbot for commit a9ed7cd. Bugbot is set up for automated code reviews on this repo. Configure here.