Skip to content
This repository was archived by the owner on Nov 2, 2026. It is now read-only.

chore: correct commented default class name to AICompletionConfigDefault - #38

Merged
keelerm84 merged 1 commit into
mainfrom
devin/1786352880-fix-default-comment
Aug 27, 2026
Merged

keelerm84 merged 1 commit into
mainfrom
devin/1786352880-fix-default-comment

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The four getting_started completion examples show a commented-out resiliency default that references AIConfig, a class that no longer exists in launchdarkly-server-sdk-ai 1.x. Anyone uncommenting it hits ImportError/NameError. The current name is AICompletionConfigDefault, which features/create_model already uses.

-#   default = AIConfig(
+#   default = AICompletionConfigDefault(

No dependency changes: every manifest uses floor/caret constraints and poetry.lock is gitignored, so poetry install already resolves to the latest within-major versions (launchdarkly-server-sdk-ai 1.2.0, launchdarkly-observability 1.3.1, launchdarkly-server-sdk-ai-langchain 0.8.0, langchain 1.3.14). google-genai stays on ^1.30.0 since 2.x would be a major jump.

How it was tested

  • poetry install in all 10 example directories against latest published deps, then imported each example module — all succeed (the OpenAI example instantiates OpenAI() at import time, so it needs OPENAI_API_KEY, which is unrelated to this change).
  • Ran the LangChain path end-to-end against a real LaunchDarkly SDK key with an AICompletionConfigDefault default and an Anthropic model, confirming the corrected class name works and metrics are tracked:
init True
enabled True claude-sonnet-4-5 anthropic
response: I can help you with a wide variety of tasks! ...
duration 6328 success True tokens (20, 198, 218)

Limitations

  • The examples could not be run against real AI Configs: none of the example config keys (sample-completion, sample-agent, sample-judge, ...) exist in the hello-app LaunchDarkly project (FLAG_NOT_FOUND), and provider keys for OpenAI/Gemini/Bedrock are not available here. The end-to-end run above used a local default plus an Anthropic key instead.
  • Pre-existing, not fixable here: launchdarkly-observability's generated GraphQL client imports the deprecated websockets.client API, emitting DeprecationWarning on import. That belongs to the observability SDK.

Link to Devin session: https://app.devin.ai/sessions/d518388a79344d6ebcdaaeedbef361d0
Requested by: @jsonbailey


Note

Overview
Updates the commented resiliency default in four getting_started completion samples (Bedrock, Gemini, LangChain, OpenAI) so it references AICompletionConfigDefault instead of the removed AIConfig type from launchdarkly-server-sdk-ai 1.x.

Only documentation-style comments change; live completion_config calls are untouched. Copying the example default no longer fails at import with NameError/ImportError.

Reviewed by Cursor Bugbot for commit a9ed7cd. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PR created by Devin label Aug 10, 2026
@kinyoklion
kinyoklion marked this pull request as ready for review August 10, 2026 22:08
@kinyoklion
kinyoklion requested a review from a team as a code owner August 10, 2026 22:08
@keelerm84
keelerm84 merged commit 023e02b into main Aug 27, 2026
5 checks passed
@keelerm84
keelerm84 deleted the devin/1786352880-fix-default-comment branch August 27, 2026 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

devin-pr PR created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants