Repository navigation
Conversation
beekld
marked this pull request as ready for review
November 2, 2026 21:05
beekld
force-pushed
the
bklimt/SDK-3425/unrecoverable-error-log
branch
from
November 2, 2026 21:31
7812ed4 to
44e243b
Compare
beekld
force-pushed
the
bklimt/SDK-3425/unrecoverable-error-log
branch
from
November 2, 2026 21:59
44e243b to
4fda77d
Compare
beekld
force-pushed
the
bklimt/SDK-3425/unrecoverable-error-log
branch
from
November 3, 2026 00:05
4fda77d to
7674d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#489 changed the ERROR log for an unrecoverable HTTP status, such as a 401, from "giving up permanently" to "will not retry until restarted." The synchronizer does stop, but the data system parks it and starts it again after a delay. An operator could read "restarted" as "restart the process," which also resets the park backoff. The message now says that the data system will retry the synchronizer after a delay.
Note
Overview
Updates the ERROR log emitted when an HTTP status is treated as unrecoverable by the synchronizer (e.g. most 4xx besides 400/408/429).
The message no longer says the error will not retry until restarted, which could be read as needing a process restart. It now states that the data system will retry it after a delay, matching how the synchronizer is parked and restarted by the data system rather than giving up permanently.
Reviewed by Cursor Bugbot for commit 7674d5a. Bugbot is set up for automated code reviews on this repo. Configure here.