Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 193489d. Configure here.
beekld
force-pushed
the
bklimt/SDK-3425/synchronizer-off-result
branch
from
November 2, 2026 21:59
7f8c484 to
ee27cca
Compare
beekld
force-pushed
the
bklimt/SDK-3425/synchronizer-off-result
branch
from
November 3, 2026 00:05
ee27cca to
6b4d9a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Since #489, the data system has silently ignored a synchronizer result with
State: Off. The result's error was dropped, the status didn't change, and the data system kept waiting on that synchronizer. A synchronizer isn't supposed to reportOff, butStateis a public field, and custom synchronizers can set it.This PR treats an
Offresult as an unexpected failure. The data system reportsInterruptedwith the result's error and parks the synchronizer.It also changes how the data system handles a synchronizer that closes its result channel on its own. That used to count as a fallback, which with a single synchronizer restarted it at once with no delay. A synchronizer that kept ending its results could then restart in a tight loop. The data system now treats this as an unexpected failure too, and parks the synchronizer.
Note
Overview
Fixes FDv2 synchronizer handling for two invalid behaviors that could leave the client stuck or spinning.
State: Offfrom a synchronizer is no longer ignored. The data system now surfacesInterruptedwith the result’s error, marks the outcome as an unexpected failure, and parks the synchronizer (or restarts from the first synchronizer if the SDK key changed mid-run).When a synchronizer closes its own result channel, the loop no longer treats that as a normal fallback (which could restart a lone synchronizer immediately in a tight loop). It reports
Interruptedwith a fixed unknown error, then parks or restarts the same way as other unexpected failures.Tests assert both paths: status/error reporting and that the primary synchronizer does not run again while parked.
Reviewed by Cursor Bugbot for commit 6b4d9a8. Bugbot is set up for automated code reviews on this repo. Configure here.