Skip to content

chore: load Hub publish creds via release-secrets SSM - #243

Merged
tknopp-ld merged 2 commits into
mainfrom
chore/publish-image-ssm-creds
Aug 14, 2026
Merged

tknopp-ld merged 2 commits into
mainfrom
chore/publish-image-ssm-creds

Conversation

@tknopp-ld

Copy link
Copy Markdown
Contributor

Summary

  • Update .github/workflows/publish-image.yml to obtain Docker Hub credentials the same way as ld-find-code-refs / other public LD images: launchdarkly/gh-actions/actions/release-secrets → SSM /global/services/docker/public/{username,token} via vars.AWS_ROLE_ARN.
  • Drop reliance on repo DOCKERHUB_USERNAME / DOCKERHUB_TOKEN.
  • Fail closed if credentials did not load (no values logged).
  • Docs (DEVELOPMENT.md, AGENTS.md) + CHANGELOG [Unreleased] updated.

Why this should work

  • Same action pin, role var name, and SSM paths as the working ld-find-code-refs release workflow.
  • Adds permissions.id-token: write required for OIDC assume-role.
  • Login uses env.DOCKER_USERNAME / env.DOCKER_TOKEN set by release-secrets (masked); workflow never echoes them.

Prerequisite before first successful run

  • Ensure this repository has Actions variable AWS_ROLE_ARN pointing at the same release role used by ld-find-code-refs (OIDC trust for launchdarkly/find-code-references-in-pull-request + SSM read on those parameters). If the var/trust is missing, the verify step fails safely.

Test plan

  • Merge
  • Confirm AWS_ROLE_ARN is set for this repo (or add it)
  • Run Publish Docker image with version: 2.3.0
  • docker pull launchdarkly/find-code-references-in-pull-request:2.3.0
  • Optional couscous smoke: /docker@v2.3.0 with default Hub image

Made with Cursor

Match ld-find-code-refs: OIDC + vars.AWS_ROLE_ARN + public Docker SSM
parameters, instead of repo DOCKERHUB_* secrets.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tknopp-ld
tknopp-ld requested a review from a team as a code owner August 14, 2026 17:32
Checkout vX.Y.Z so the image matches the Action release, pin
linux/amd64 + explicit Dockerfile, disable provenance/sbom for Hub,
and verify the pushed tag before finishing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tknopp-ld
tknopp-ld merged commit e58dff8 into main Aug 14, 2026
8 checks passed
@tknopp-ld
tknopp-ld deleted the chore/publish-image-ssm-creds branch August 14, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants