Skip to content

fix: exclude documentation files from NuGet package builds #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinyoklion wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: exclude documentation files from NuGet package builds #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37f1238
chore: exclude documentation files from NuGet package builds
devin-ai-integration[bot] May 22, 2026
6227fe7
fix: use None instead of Content for doc files, pack README for NuGet…
devin-ai-integration[bot] May 26, 2026
b53259a
Merge branch 'main' into devin/1779486323-exclude-docs-from-pack
kinyoklion May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions pkgs/dotnet-server-sdk-consul/src/LaunchDarkly.ServerSdk.Consul.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<RootNamespace>LaunchDarkly.Sdk.Server.Integrations</RootNamespace>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand Down Expand Up @@ -47,24 +48,31 @@
</ItemGroup>

<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Content Include="..\SECURITY.md">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\SECURITY.md">
<Link>SECURITY.md</Link>
</Content>
<Pack>false</Pack>
</None>
</ItemGroup>

<PropertyGroup>
Expand Down
32 changes: 20 additions & 12 deletions pkgs/dotnet-server-sdk-dynamodb/src/LaunchDarkly.ServerSdk.DynamoDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<RootNamespace>LaunchDarkly.Sdk.Server.Integrations</RootNamespace>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand All @@ -42,24 +43,31 @@
<ProjectReference Include="../../sdk/server/src/LaunchDarkly.ServerSdk.csproj" />
</ItemGroup>
<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Content Include="..\SECURITY.md">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\SECURITY.md">
<Link>SECURITY.md</Link>
</Content>
<Pack>false</Pack>
</None>
</ItemGroup>

<PropertyGroup>
Expand Down
27 changes: 17 additions & 10 deletions pkgs/dotnet-server-sdk-redis/src/LaunchDarkly.ServerSdk.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<RootNamespace>LaunchDarkly.Sdk.Server.Integrations</RootNamespace>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand All @@ -42,21 +43,27 @@
<ProjectReference Include="../../sdk/server/src/LaunchDarkly.ServerSdk.csproj" />
</ItemGroup>
<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Content Include="..\SECURITY.md">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\SECURITY.md">
<Link>SECURITY.md</Link>
</Content>
<Pack>false</Pack>
</None>
</ItemGroup>

<PropertyGroup>
Expand Down
27 changes: 17 additions & 10 deletions pkgs/sdk/client/src/LaunchDarkly.ClientSdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

<!-- fail if XML comments are missing or invalid -->
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand Down Expand Up @@ -125,21 +126,27 @@
</Compile>
</ItemGroup>
<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Content Include="..\toc.yml">
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
<None Include="..\toc.yml">
<Link>toc.yml</Link>
</Content>
<Pack>false</Pack>
</None>
</ItemGroup>
<PropertyGroup Condition="'$(Configuration)'=='Release'">
<AssemblyOriginatorKeyFile>../../../../LaunchDarkly.ClientSdk.snk</AssemblyOriginatorKeyFile>
Expand Down
37 changes: 23 additions & 14 deletions pkgs/sdk/server-ai/src/LaunchDarkly.ServerSdk.Ai.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

<!-- fail if XML comments are missing or invalid -->
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand All @@ -57,27 +58,35 @@
<ProjectReference Include="../../server/src/LaunchDarkly.ServerSdk.csproj" />
</ItemGroup>
<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Ai.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Ai.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Server.Ai.md</Link>
</Content>
<Content Include="..\docs-src\README.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\README.md">
<Link>docs-src\README.md</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
</ItemGroup>

<PropertyGroup Condition="'$(Configuration)'=='Release'">
Expand Down
62 changes: 38 additions & 24 deletions pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

<!-- fail if XML comments are missing or invalid -->
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand All @@ -58,42 +59,55 @@
</ItemGroup>

<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\CONTRIBUTING.md">
<Pack>false</Pack>
</None>
<None Include="..\CONTRIBUTING.md">
<Link>CONTRIBUTING.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Json.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Json.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Json.md</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.md</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Integrations.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Integrations.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Server.Integrations.md</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Interfaces.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Interfaces.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Server.Interfaces.md</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Server.md</Link>
</Content>
<Content Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Subsystems.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\namespaces\LaunchDarkly.Sdk.Server.Subsystems.md">
<Link>docs-src\namespaces\LaunchDarkly.Sdk.Server.Subsystems.md</Link>
</Content>
<Content Include="..\docs-src\README.md">
<Pack>false</Pack>
</None>
<None Include="..\docs-src\README.md">
<Link>docs-src\README.md</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Content Include="..\README.md">
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
</Content>
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
</ItemGroup>

<PropertyGroup Condition="'$(Configuration)'=='Release'">
Expand Down
21 changes: 15 additions & 6 deletions pkgs/telemetry/src/LaunchDarkly.ServerSdk.Telemetry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

<!-- fail if XML comments are missing or invalid -->
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Configurations>Debug;Release;DebugLocalReferences</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
Expand All @@ -58,15 +59,23 @@
</ItemGroup>

<ItemGroup>
<Content Include="..\CHANGELOG.md">
<None Include="..\CHANGELOG.md">
<Link>CHANGELOG.md</Link>
</Content>
<Content Include="..\docfx.json">
<Pack>false</Pack>
</None>
<None Include="..\docfx.json">
<Link>docfx.json</Link>
</Content>
<Content Include="..\index.md">
<Pack>false</Pack>
</None>
<None Include="..\index.md">
<Link>index.md</Link>
</Content>
<Pack>false</Pack>
</None>
<None Include="..\README.md">
<Link>README.md</Link>
<Pack>true</Pack>
<PackagePath>\</PackagePath>
</None>
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry package references non-existent README.md file

High Severity

The telemetry project adds <PackageReadmeFile>README.md</PackageReadmeFile> and a <None Include="..\README.md"> entry with <Pack>true</Pack>, but there is no README.md file in the pkgs/telemetry/ directory. Unlike every other project modified in this PR, the telemetry package is newly referencing a file that doesn't exist, rather than converting an existing Content entry. This will cause the NuGet pack to fail at build time.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b53259a. Configure here.

</ItemGroup>

<PropertyGroup Condition="'$(Configuration)'=='Release'">
Expand Down
Loading