fix(runtime): align update version and host errors - #169
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
Merging this PR will degrade performance by 22.08%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | yaml |
3.7 ms | 5.4 ms | -31.02% |
| ❌ | small |
107.6 µs | 144 µs | -25.3% |
| ❌ | json-small |
193 µs | 256 µs | -24.61% |
| ❌ | BenchmarkFindCatalogCommand |
6.5 µs | 8.6 µs | -24.27% |
| ❌ | BenchmarkCatalogJSON |
2.3 ms | 3 ms | -23.74% |
| ❌ | small |
149.2 µs | 194.6 µs | -23.32% |
| ❌ | large |
1.9 ms | 2.4 ms | -23.23% |
| ❌ | json |
990.7 µs | 1,283.8 µs | -22.84% |
| ❌ | large |
1.8 ms | 2.3 ms | -22.75% |
| ❌ | BenchmarkParseNormalize |
4.8 ms | 6.2 ms | -22.5% |
| ❌ | yaml-large |
12.5 ms | 16 ms | -22.17% |
| ❌ | BenchmarkFormatTableInferredColumns |
727.2 µs | 934.1 µs | -22.15% |
| ❌ | large |
1.3 ms | 1.6 ms | -21.52% |
| ❌ | miss |
3 ms | 3.7 ms | -21.03% |
| ❌ | table |
577.2 µs | 729.7 µs | -20.9% |
| ❌ | hit |
3 ms | 3.8 ms | -20.66% |
| ❌ | small |
83.4 µs | 104.3 µs | -20.08% |
| ❌ | json-large |
2.8 ms | 3.4 ms | -19.4% |
| ❌ | small |
113.7 µs | 140.9 µs | -19.29% |
| ❌ | large |
1.1 ms | 1.3 ms | -18.75% |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/update-host-errors (0a99ecb) with main (690d397)
Summary
updatecompare the sameVersionInfo()value reported by version commands.Verification
go test -count=1 ./pkg/lathe -run TestRunGitHubUpdateUsesReportedVersiongo test -count=1 ./pkg/runtime -run TestLoadHostOptions_UnknownExplicitHostIsActionablemake checkgo test -race -count=1 ./...Compatibility
No catalog schema or generated command shape changes. Update checks now honor Go module build information, and missing-host errors keep
not_authenticated, exit code 4, anderrors.Is(ErrNotAuthenticated)while improving the message and hint.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.