Skip to content

fix(runtime): align update version and host errors - #169

Merged
samzong merged 1 commit into
mainfrom
fix/update-host-errors
Aug 30, 2026
Merged

fix(runtime): align update version and host errors#169
samzong merged 1 commit into
mainfrom
fix/update-host-errors

Conversation

@samzong

@samzong samzong commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make update compare the same VersionInfo() value reported by version commands.
  • Return host-specific actionable authentication errors when a resolved host has no credentials.

Verification

  • go test -count=1 ./pkg/lathe -run TestRunGitHubUpdateUsesReportedVersion
  • go test -count=1 ./pkg/runtime -run TestLoadHostOptions_UnknownExplicitHostIsActionable
  • make check
  • go test -race -count=1 ./...
  • Rebuilt Tokener against this Lathe checkout and verified that a control-character hostname stays inside a valid JSON error envelope with exit code 4.

Compatibility

No catalog schema or generated command shape changes. Update checks now honor Go module build information, and missing-host errors keep not_authenticated, exit code 4, and errors.Is(ErrNotAuthenticated) while improving the message and hint.

Checklist

  • Tests or focused verification cover the changed surface.
  • User-facing behavior changes are documented in this PR.
  • Generated output under internal/generated/, .cache/, and ad-hoc skills/<cli-name>/ directories is not committed.
  • Commits are signed off when this is ready to merge.

Signed-off-by: samzong <samzong.lu@gmail.com>
@codspeed-hq

codspeed-hq Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 22.08%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 21 regressed benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
yaml 3.7 ms 5.4 ms -31.02%
small 107.6 µs 144 µs -25.3%
json-small 193 µs 256 µs -24.61%
BenchmarkFindCatalogCommand 6.5 µs 8.6 µs -24.27%
BenchmarkCatalogJSON 2.3 ms 3 ms -23.74%
small 149.2 µs 194.6 µs -23.32%
large 1.9 ms 2.4 ms -23.23%
json 990.7 µs 1,283.8 µs -22.84%
large 1.8 ms 2.3 ms -22.75%
BenchmarkParseNormalize 4.8 ms 6.2 ms -22.5%
yaml-large 12.5 ms 16 ms -22.17%
BenchmarkFormatTableInferredColumns 727.2 µs 934.1 µs -22.15%
large 1.3 ms 1.6 ms -21.52%
miss 3 ms 3.7 ms -21.03%
table 577.2 µs 729.7 µs -20.9%
hit 3 ms 3.8 ms -20.66%
small 83.4 µs 104.3 µs -20.08%
json-large 2.8 ms 3.4 ms -19.4%
small 113.7 µs 140.9 µs -19.29%
large 1.1 ms 1.3 ms -18.75%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/update-host-errors (0a99ecb) with main (690d397)

Open in CodSpeed

@samzong
samzong merged commit 7ec8e13 into main Aug 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant