feat(output): support table column labels in overlays - #166
Merged
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
Contributor
Merging this PR will improve performance by 16.06%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | large |
2.1 ms | 1.7 ms | +26.04% |
| ⚡ | table |
796.9 µs | 651.3 µs | +22.37% |
| ⚡ | yaml |
5.4 ms | 4.6 ms | +18.38% |
| ⚡ | small |
193 µs | 166.4 µs | +15.97% |
| ⚡ | BenchmarkFindCatalogCommand |
8.7 µs | 7.6 µs | +14.48% |
| ⚡ | large |
2.4 ms | 2.1 ms | +14.44% |
| ⚡ | large |
1.6 ms | 1.4 ms | +13.84% |
| ⚡ | json-small |
255.9 µs | 227.8 µs | +12.36% |
| ⚡ | small |
142.6 µs | 127.5 µs | +11.81% |
| ⚡ | BenchmarkCatalogJSON |
3 ms | 2.6 ms | +11.77% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing feat/table-column-overrides (61706d7) with main (c383c72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output.default_columnsandoutput.column_labelsto command overlays.Verification
go test ./pkg/runtime -run 'TestFormatOutput_(TableUsesNestedListPath|TableUsesConfiguredColumnLabels)$' -count=1go test ./internal/codegen/render -run 'TestRenderModule_AppliesOverlay|TestMergeOverlayModule_OutputColumns' -count=1go test ./internal/overlay -run TestLoadDir_ParsesExtendedFields -count=1make checkgo test -race ./...Compatibility
CommandSpecliterals may include the optionalOutputHints.ColumnLabelsfield.runtime.SchemaVersionremains 11 because existing generated modules remain compatible.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.