Repository navigation
Mini-card thumbnails: renditions and favicon fallback on a broken picture (#2058) - #2060
Merged
Merged
Conversation
larspohlmann
changed the base branch from
feature/2055-richer-source-mini-cards
to
develop
November 6, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2057. Merge that first; this PR then retargets to
develop.The 104×68 thumbnail of a Trending story's "more sources" mini card:
RenditionsDirectivewith a newMINI_CARD_THUMB_SIZES = '104px'. Expanding a story now fetches small renditions, not full-size pictures.src(fallBackToSrc()). If that also fails, the card shows the favicon box that a source without a picture gets. Only that card changes; the others keep their pictures.The per-card error state is a
linkedSignalset of failed copy ids. It resets when the copies change.Verified
npm run checkis green (6364 tests).srcset/sizes, the retry of the plainsrc, and the per-card favicon fallback.currentSrc≠src). Pointing one picture at a 404 swapped just that card to the favicon box.Closes #2058