Repository navigation
fix(#2056): an article URL counts as one Trending source - #2059
Merged
Merged
Conversation
…y feeds carry it A story's source count took every followed feed with one of its entries, so a syndicated or aggregated copy of the same article read as broader coverage, and copies of the lead from outside the story were added on top. Now only the lowest-id copy of an article URL the reader can see in the story counts, the rule the list's duplicate collapse uses; the lead's copies still show on the card but no longer add a source or re-rank it. Social posts always count.
…er; the explain command counts feeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2056
What changes
TrendingStoryRepository::VISIBLE_STORIES) now drops a story member if a lower-id copy with the sameurl_hashsits in a feed the reader follows. This is the ruleDuplicateCollapseDqluses, applied to the story's own members. It feeds the source count, the reader's minimum and the two-article-feeds rule.withCopiesstill shows a lead's copies from other feeds on the card, but no longer raisesoutletCount.withMoreOutlets,RankedStoryModel::compareand the re-sort inwithLeadCopiesare gone: the order comes from SQL alone now.app:trending:explainnow prints "N feeds" instead of "N outlets". The build-time count is raw feeds and stays that way on purpose, as an upper bound on any reader's count.Not changed
TrendingGrouping::stories) still counts raw feeds. A collapse across all feeds can keep a copy the reader doesn't follow, which would drop stories that reader should see.url_hashintotrending_story_entrywould make the new subquery a single index probe. It needs a migration and today's version is already index-backed, so it is left out.Verification
Chapter, which this change doesn't touch).infection:diff: 100% covered-code MSI.