Skip to content

fix(#2053): duplicated posts keep their "Also in" pills in the magazine - #2054

Merged
larspohlmann merged 3 commits into
developfrom
fix/2053-duplicate-post-pills
Nov 6, 2026
Merged

larspohlmann merged 3 commits into
developfrom
fix/2053-duplicate-post-pills

Conversation

@larspohlmann

Copy link
Copy Markdown
Owner

Closes #2053

What

#2037 (#2036) replaced the magazine's whole duplicates footer with "x more sources" mini cards. The redesign was meant only for a Trending story's other outlets. A post that appears in several feeds lost its "Also in" pills.

  • app-more-sources, the footer slot every magazine block renders, now chooses between two footers:
  • The pill footer only exists on a card that has copies.
  • The story footer stretches across a kicker card (align-self: stretch). The kicker card's align-items: flex-start shrank its grid to the content.
  • docs/design-language.md now says which entries get which footer.

The pills are untouched. In a kicker card their top rule still ends at their content width, as it did before #2037.

Testing

  • npm run check is green: 476 suites, 6357 tests.
  • more-sources spec: a non-story duplicate renders the "Also in" pills and no mini cards; a story renders mini cards and no pills.
  • The hero spec's pre-feat(#2036): magazine "x more sources" footer that opens into mini cards #2037 test (duplicate copy, pill, then popover, then open) is restored, next to a story test through the mini card.
  • The Trending Playwright smoke passes in both layouts.
  • Live check on :4200: a stubbed duplicated post in the magazine shows "Also in" with two pills.

@larspohlmann
larspohlmann merged commit de3587d into develop Nov 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magazine: duplicate posts lost their "Also in" pills (#2036 regression)

1 participant