Repository navigation
fix(#2053): duplicated posts keep their "Also in" pills in the magazine - #2054
Merged
Merged
Conversation
… opens into mini cards
…he story footer reads duplicates directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2053
What
#2037 (#2036) replaced the magazine's whole duplicates footer with "x more sources" mini cards. The redesign was meant only for a Trending story's other outlets. A post that appears in several feeds lost its "Also in" pills.
app-more-sources, the footer slot every magazine block renders, now chooses between two footers:<app-entry-duplicates>, exactly as before feat(#2036): magazine "x more sources" footer that opens into mini cards #2037 ("Also in" pills, a popover with the copy's row).align-self: stretch). The kicker card'salign-items: flex-startshrank its grid to the content.docs/design-language.mdnow says which entries get which footer.The pills are untouched. In a kicker card their top rule still ends at their content width, as it did before #2037.
Testing
npm run checkis green: 476 suites, 6357 tests.more-sourcesspec: a non-story duplicate renders the "Also in" pills and no mini cards; a story renders mini cards and no pills.