Skip to content

fix(slides): restore presentation aliases - #2164

Merged
liangshuo-1 merged 1 commit into
mainfrom
fix/slides-presentation-aliases
Aug 3, 2026
Merged

fix(slides): restore presentation aliases#2164
liangshuo-1 merged 1 commit into
mainfrom
fix/slides-presentation-aliases

Conversation

@liangshuo-1

@liangshuo-1 liangshuo-1 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restore the shared Slides presentation aliases for +add-slide and +delete-slide. PR #2120 was based before the alias framework from #2146 and declared standalone --presentation flags, leaving the new shortcuts outside the domain contract.

Changes

  • Reuse requiredPresentationRefFlag() in both new shortcuts.
  • Extend the Slides alias contract and dry-run E2E coverage for the new commands.

Test Plan

  • make unit-test in a clean worktree
  • go vet ./...
  • gofmt -l . produces no output
  • go mod tidy leaves go.mod and go.sum unchanged
  • golangci-lint, lint module tests, and source-contract lint pass
  • Built-binary dry-run E2E verifies --presentation-id and --presentation-token

Related Issues

Summary by CodeRabbit

  • Bug Fixes
    • Standardized presentation references for adding and deleting slides.
    • Added support for the --presentation-id and --presentation-token aliases in slide commands.
    • Updated validation coverage to ensure both shortcuts accept the shared presentation options.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68b1b365-7637-4ee7-8470-3ba2869153b5

📥 Commits

Reviewing files that changed from the base of the PR and between ba10438 and edce1c9.

📒 Files selected for processing (4)
  • shortcuts/slides/shortcuts_alias_test.go
  • shortcuts/slides/slides_add_slide.go
  • shortcuts/slides/slides_delete_slide.go
  • tests/cli_e2e/slides/slides_slide_add_delete_dryrun_test.go

📝 Walkthrough

Walkthrough

The add-slide and delete-slide shortcuts now use the shared required presentation reference flag configuration. Alias coverage and dry-run tests use --presentation-id and --presentation-token.

Changes

Slides presentation flag aliases

Layer / File(s) Summary
Shared presentation flag wiring and validation
shortcuts/slides/slides_add_slide.go, shortcuts/slides/slides_delete_slide.go, shortcuts/slides/shortcuts_alias_test.go, tests/cli_e2e/slides/slides_slide_add_delete_dryrun_test.go
The slide commands use requiredPresentationRefFlag(). Alias coverage includes both commands. Dry-run tests use --presentation-id for add-slide and --presentation-token for delete-slide.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: r0bynzhu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes restoring the Slides presentation aliases.
Description check ✅ Passed The description covers the summary, changes, verification steps, and related issues with sufficient detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/slides-presentation-aliases

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Aug 3, 2026
@liangshuo-1
liangshuo-1 marked this pull request as ready for review August 3, 2026 13:00
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@edce1c97972c87eba397073968074a295fa97cb4

🧩 Skill update

npx skills add larksuite/cli#fix/slides-presentation-aliases -y -g

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.69%. Comparing base (2a16134) to head (edce1c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
+ Coverage   75.65%   75.69%   +0.03%     
==========================================
  Files         940      942       +2     
  Lines       99876   100079     +203     
==========================================
+ Hits        75564    75750     +186     
- Misses      18530    18537       +7     
- Partials     5782     5792      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangshuo-1
liangshuo-1 merged commit e8202c2 into main Aug 3, 2026
32 of 42 checks passed
@liangshuo-1
liangshuo-1 deleted the fix/slides-presentation-aliases branch August 3, 2026 13:12
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant