fix(slides): restore presentation aliases - #2164
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe add-slide and delete-slide shortcuts now use the shared required presentation reference flag configuration. Alias coverage and dry-run tests use ChangesSlides presentation flag aliases
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@edce1c97972c87eba397073968074a295fa97cb4🧩 Skill updatenpx skills add larksuite/cli#fix/slides-presentation-aliases -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
+ Coverage 75.65% 75.69% +0.03%
==========================================
Files 940 942 +2
Lines 99876 100079 +203
==========================================
+ Hits 75564 75750 +186
- Misses 18530 18537 +7
- Partials 5782 5792 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Restore the shared Slides presentation aliases for
+add-slideand+delete-slide. PR #2120 was based before the alias framework from #2146 and declared standalone--presentationflags, leaving the new shortcuts outside the domain contract.Changes
requiredPresentationRefFlag()in both new shortcuts.Test Plan
make unit-testin a clean worktreego vet ./...gofmt -l .produces no outputgo mod tidyleavesgo.modandgo.sumunchanged--presentation-idand--presentation-tokenRelated Issues
Summary by CodeRabbit
--presentation-idand--presentation-tokenaliases in slide commands.