Skip to content

fix(web): stabilize Home and Studio route titles - #41654

Merged
lyzno1 merged 1 commit into
mainfrom
codex/snp-740-stable-route-titles
Sep 2, 2026
Merged

fix(web): stabilize Home and Studio route titles#41654
lyzno1 merged 1 commit into
mainfrom
codex/snp-740-stable-route-titles

Conversation

@lyzno1

@lyzno1 lyzno1 commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • move the fixed Home and Studio titles from client effects to their App Router page metadata owners
  • reuse the existing server-side localized metadata helper and root branding template
  • remove the duplicate title effects from the Home and Apps content components

Fixes SNP-740

Validation

  • vp staged
  • vp test run --project unit app/__tests__/route-metadata.spec.ts features/home/home-content/__tests__/home-content.spec.tsx app/components/apps/__tests__/index.spec.tsx (65 tests)
  • browser-verified direct loads and SPA navigation for / and /apps on localhost:3000

Screenshots

Not applicable; this changes document metadata without changing visible page layout.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Sep 2, 2026
@lyzno1
lyzno1 enabled auto-merge September 2, 2026 08:51
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.93%. Comparing base (bda60a3) to head (300fab0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #41654      +/-   ##
==========================================
- Coverage   86.93%   86.93%   -0.01%     
==========================================
  Files        5309     5311       +2     
  Lines      306039   306044       +5     
  Branches    61329    61329              
==========================================
+ Hits       266061   266063       +2     
- Misses      34691    34694       +3     
  Partials     5287     5287              
Flag Coverage Δ
dify-ui 93.75% <ø> (ø)
web 87.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit e577c00 Sep 2, 2026
52 checks passed
@lyzno1
lyzno1 deleted the codex/snp-740-stable-route-titles branch September 2, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants