refactor(openapi): inject file upload service - #41606
Merged
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
linw1995
previously approved these changes
Sep 3, 2026
hjlarry
force-pushed
the
refactor/openapi-files
branch
from
September 3, 2026 04:07
5dad352 to
c62f3e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/console-files #41606 +/- ##
=======================================================
Coverage 86.96% 86.96%
=======================================================
Files 5322 5322
Lines 306772 306771 -1
Branches 61453 61453
=======================================================
+ Hits 266775 266786 +11
+ Misses 34704 34691 -13
- Partials 5293 5294 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
41tair
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #39993
Stack: #41587
Depends on #41603.
FileServicethroughapplication_services()instead of constructing it from Flask database globals in the OpenAPI controller@returns/FileResponseserialization contractValueErrorfallback so their intended HTTP errors are reachableBehavior changes
413 file_too_largeinstead of a generic400 bad_request415 unsupported_file_typeinstead of a generic400 bad_requestfile_extension_blockedinstead ofbad_request