Skip to content

fix(ci): pin goosefs-sdk to 0.1.5#7798

Merged
westonpace merged 2 commits into
lance-format:mainfrom
zhangyue19921010:pin-goosefs-sdk-0.1.5
Jul 15, 2026
Merged

fix(ci): pin goosefs-sdk to 0.1.5#7798
westonpace merged 2 commits into
lance-format:mainfrom
zhangyue19921010:pin-goosefs-sdk-0.1.5

Conversation

@zhangyue19921010

@zhangyue19921010 zhangyue19921010 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Pins goosefs-sdk to 0.1.5 because 0.1.6 fails to compile on Linux due to a missing std::ffi::CString import. This pin can be removed once upstream publishes a fixed release.

error[E0433]: cannot find type `CString` in this scope
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/goosefs-sdk-0.1.6/src/cache/store/uring/store.rs:314:23
    |
314 |         let cstring = CString::new(path)
    |                       ^^^^^^^ use of undeclared type `CString`

Summary by CodeRabbit

  • Bug Fixes
    • Updated GooseFS integration to use a compatible SDK version, improving reliability for supported storage operations.

@github-actions github-actions Bot added A-encoding Encoding, IO, file reader/writer bug Something isn't working labels Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Cargo.lock is excluded by !**/*.lock
  • java/lance-jni/Cargo.lock is excluded by !**/*.lock
  • python/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ecfef6ac-3c55-4897-8a14-26f605c83d37

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
📝 Walkthrough

Walkthrough

The workspace pins goosefs-sdk to version 0.1.5. The lance-io crate declares it as an optional dependency and enables it through the goosefs feature.

Changes

GooseFS SDK integration

Layer / File(s) Summary
Pin and enable GooseFS SDK
Cargo.toml, rust/lance-io/Cargo.toml
The workspace pins goosefs-sdk to =0.1.5, while lance-io adds it as an optional dependency and includes it in the goosefs feature.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: jackye1995, wjones127, xuanwo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: pinning goosefs-sdk to version 0.1.5.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added A-python Python bindings A-java Java bindings + JNI A-deps Dependency updates labels Jul 15, 2026
@zhangyue19921010

zhangyue19921010 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Looks like OpenDAL encountered a similar issue @Xuanwo would mind to take a look to unblock ci? Thanks!

https://github.com/apache/opendal/actions/runs/29414775440/job/87350065742

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@westonpace westonpace merged commit 8a8355a into lance-format:main Jul 15, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Dependency updates A-encoding Encoding, IO, file reader/writer A-java Java bindings + JNI A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants