Skip to content

fix: bracket match query display#7796

Open
jackye1995 wants to merge 1 commit into
lance-format:mainfrom
jackye1995:jack/wrap-metrics-node-name
Open

fix: bracket match query display#7796
jackye1995 wants to merge 1 commit into
lance-format:mainfrom
jackye1995:jack/wrap-metrics-node-name

Conversation

@jackye1995

@jackye1995 jackye1995 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Wrap MatchQuery display output in brackets so external metric suffixes render as [name]: metrics instead of making the separator look like part of the query text.

Local builds were not run per request.

Summary by CodeRabbit

  • Style
    • Updated Full Text Search (FTS) query plan output to wrap the MatchQuery label in square brackets for the default/verbose display.
  • Tests
    • Adjusted FTS execution-plan expectation strings and snapshots to match the updated MatchQuery formatting.

@github-actions github-actions Bot added the bug Something isn't working label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e065344a-d060-49e5-9c2a-0f2461b010ed

📥 Commits

Reviewing files that changed from the base of the PR and between 2c5f0f9 and 39ac6d5.

📒 Files selected for processing (4)
  • rust/lance/src/dataset/mem_wal/memtable/flush.rs
  • rust/lance/src/dataset/scanner.rs
  • rust/lance/src/dataset/tests/dataset_aggregate.rs
  • rust/lance/src/io/exec/fts.rs

📝 Walkthrough

Walkthrough

The MatchQueryExec display formatter now wraps its MatchQuery output in square brackets, and FTS execution-plan test expectations are updated accordingly.

Changes

MatchQuery display formatting

Layer / File(s) Summary
Update MatchQuery plan formatting
rust/lance/src/io/exec/fts.rs
The default and verbose display formats change from MatchQuery: ... to [MatchQuery: ...].
Align FTS plan expectations
rust/lance/src/dataset/mem_wal/memtable/flush.rs, rust/lance/src/dataset/scanner.rs, rust/lance/src/dataset/tests/dataset_aggregate.rs
FTS plan and aggregate test expectations now use the bracketed MatchQuery representation across query, boost, prefilter, unindexed-row, and fast-search cases.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wjones127, xuanwo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately summarizes the MatchQuery display-format change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jackye1995 jackye1995 force-pushed the jack/wrap-metrics-node-name branch from 2c5f0f9 to 39ac6d5 Compare July 15, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant