-
Notifications
You must be signed in to change notification settings - Fork 766
chore(python): python 3.14 support #7728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
199ab24
879bedd
fce76db
e8c6f9b
ab3ec2f
3d1738d
2059aec
8b04753
d440bdb
b355147
83f75fb
8f14c4b
0c4f2fa
5d552c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,8 +49,8 @@ build-backend = "maturin" | |
| [project.optional-dependencies] | ||
| tests = [ | ||
| "boto3", | ||
| "datasets", | ||
| "duckdb", | ||
| "datasets==4.4.0", | ||
| "duckdb>=1.5.0,<1.6.0", | ||
| "ml_dtypes", | ||
| "pillow", | ||
| "pandas", | ||
|
|
@@ -72,8 +72,8 @@ geo = [ | |
| [dependency-groups] | ||
| tests = [ | ||
| "boto3==1.40.43", | ||
| "datasets==4.1.1", | ||
| "duckdb==1.4.0", | ||
| "datasets==4.4.0", | ||
| "duckdb>=1.5.0,<1.6.0", | ||
| "ml_dtypes==0.5.3", | ||
| "pillow==11.3.0", | ||
| "pandas==2.3.3", | ||
|
|
@@ -103,7 +103,7 @@ lint.select = ["F", "E", "W", "I", "G", "TCH", "PERF", "B019"] | |
| "*.pyi" = ["E301", "E302"] | ||
|
|
||
| [tool.pyright] | ||
| pythonVersion = "3.13" | ||
| pythonVersion = "3.14" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: set -euo pipefail
printf '\n== python/pyproject.toml (around line 106) ==\n'
nl -ba python/pyproject.toml | sed -n '1,180p'
printf '\n== Search for pyright config and requires-python ==\n'
rg -n --hidden -S 'pythonVersion|requires-python|pyright' python . -g '!**/.git/**'Repository: lance-format/lance Length of output: 243 🏁 Script executed: set -euo pipefail
printf '\n== python/pyproject.toml (excerpt) ==\n'
awk 'NR>=1 && NR<=180 { printf "%4d %s\n", NR, $0 }' python/pyproject.toml
printf '\n== Search for pyright/min-version settings ==\n'
rg -n --hidden -S 'pythonVersion|requires-python|pyright|minimum version|min-version|3\.14|3\.10' python .Repository: lance-format/lance Length of output: 50375 🏁 Script executed: set -euo pipefail
printf '\n== python/pyproject.toml (lines 90-120) ==\n'
sed -n '90,120p' python/pyproject.toml | awk '{ printf "%4d %s\n", NR+89, $0 }'
printf '\n== config files mentioning pythonVersion/requires-python ==\n'
fd -HI -t f 'pyproject.toml|pyrightconfig.json|*.json|*.toml|*.yaml|*.yml' python . | head -n 50
printf '\n== exact matches in python/ directory ==\n'
rg -n --hidden -S '^(pythonVersion|requires-python)\s*=|pythonVersion|requires-python' python/pyproject.toml python/pyrightconfig.json python/.github python/.circleci python/.pre-commit-config.yaml python/.pre-commit-config.yml python/pyrightconfig.jsonRepository: lance-format/lance Length of output: 1551 🏁 Script executed: set -euo pipefail
printf '\n== python/pyproject.toml (lines 90-120) ==\n'
awk 'NR>=90 && NR<=120 { printf "%4d %s\n", NR, $0 }' python/pyproject.toml
printf '\n== likely config files under python/ ==\n'
find python -maxdepth 2 \( -name 'pyproject.toml' -o -name 'pyrightconfig.json' -o -name '*.toml' -o -name '*.json' -o -name '*.yml' -o -name '*.yaml' \) | sort
printf '\n== exact matches in python config files ==\n'
rg -n --hidden -S 'pythonVersion|requires-python' python/pyproject.toml python/pyrightconfig.json python/.pre-commit-config.yaml python/.pre-commit-config.yml python/.github python/.circleci 2>/dev/null || trueRepository: lance-format/lance Length of output: 1395 🏁 Script executed: set -euo pipefail
printf '\n== python/pyproject.toml (lines 90-120) ==\n'
awk 'NR>=90 && NR<=120 { printf "%4d %s\n", NR, $0 }' python/pyproject.toml
printf '\n== matches for pythonVersion/requires-python under python/ ==\n'
rg -n --hidden -S 'pythonVersion|requires-python' pythonRepository: lance-format/lance Length of output: 1324 Align Pyright with the supported baseline
🤖 Prompt for AI Agents
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a valid point. We should probably set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
✏️ Learnings added
|
||
| # TODO: expand this list as we fix more files. | ||
| include = [ | ||
| "python/lance/util.py", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.