Skip to content

refactor(index): introduce lance-index-core crate #7713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonpace merged 1 commit into from
Jul 15, 2026
Merged

refactor(index): introduce lance-index-core crate #7713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bumpversion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ filename = "Cargo.toml"
search = 'lance-index = {{ version = "={current_version}"'
replace = 'lance-index = {{ version = "={new_version}"'

[[tool.bumpversion.files]]
filename = "Cargo.toml"
search = 'lance-index-core = {{ version = "={current_version}"'
replace = 'lance-index-core = {{ version = "={new_version}"'

[[tool.bumpversion.files]]
filename = "Cargo.toml"
search = 'lance-io = {{ version = "={current_version}"'
Expand Down
23 changes: 23 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ members = [
"rust/lance-file",
"rust/lance-geo",
"rust/lance-index",
"rust/lance-index-core",
"rust/lance-io",
"rust/lance-linalg",
"rust/lance-namespace",
Expand Down Expand Up @@ -67,6 +68,7 @@ lance-encoding = { version = "=9.0.0-beta.24", path = "./rust/lance-encoding" }
lance-file = { version = "=9.0.0-beta.24", path = "./rust/lance-file" }
lance-geo = { version = "=9.0.0-beta.24", path = "./rust/lance-geo" }
lance-index = { version = "=9.0.0-beta.24", path = "./rust/lance-index" }
lance-index-core = { version = "=9.0.0-beta.24", path = "./rust/lance-index-core" }
lance-io = { version = "=9.0.0-beta.24", path = "./rust/lance-io", default-features = false }
lance-linalg = { version = "=9.0.0-beta.24", path = "./rust/lance-linalg" }
lance-namespace = { version = "=9.0.0-beta.24", path = "./rust/lance-namespace" }
Expand Down
23 changes: 23 additions & 0 deletions java/lance-jni/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions python/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions python/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ use lance::Result;
use lance::datatypes::Schema;
use lance_arrow::FixedSizeListArrayExt;
use lance_file::previous::writer::FileWriter as PreviousFileWriter;
use lance_index::scalar::IndexWriter;
use lance_index::vector::hnsw::{HNSW, builder::HnswBuildParams};
use lance_index::vector::kmeans::{
KMeans as LanceKMeans, KMeansAlgoFloat, KMeansParams, compute_partitions,
Expand Down Expand Up @@ -255,7 +254,7 @@ impl Hnsw {
rt().block_on(Some(py), async {
let batch = self.hnsw.to_batch()?;
let metadata = batch.schema_ref().metadata().clone();
writer.write_record_batch(batch).await?;
writer.write(&[batch]).await?;

@westonpace westonpace Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The write_record_batch method was inadvertently being provided by the IndexWriter trait but calling write is fine.

writer.finish_with_metadata(&metadata).await?;
Result::Ok(())
})?
Expand Down
33 changes: 33 additions & 0 deletions rust/lance-index-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
[package]
name = "lance-index-core"
version.workspace = true
edition.workspace = true
authors.workspace = true
license.workspace = true
repository.workspace = true
readme = "README.md"
description = "Core traits and types for Lance index plugins"
keywords.workspace = true
categories.workspace = true
rust-version.workspace = true

[dependencies]
async-trait.workspace = true
arrow-array.workspace = true
arrow-schema.workspace = true
arrow-select.workspace = true
bytes.workspace = true
datafusion-common.workspace = true
datafusion-expr.workspace = true
datafusion.workspace = true
futures.workspace = true
lance-core.workspace = true
lance-io.workspace = true
lance-select.workspace = true
prost-types.workspace = true
roaring.workspace = true
serde.workspace = true
serde_json.workspace = true

[lints]
workspace = true
Loading
Loading