feat(typescript): add TypeScript namespace client and align architecture with Python#312
Open
Xuanwo wants to merge 4 commits into
Open
feat(typescript): add TypeScript namespace client and align architecture with Python#312Xuanwo wants to merge 4 commits into
Xuanwo wants to merge 4 commits into
Conversation
wjones127
approved these changes
Jun 10, 2026
wjones127
left a comment
wjones127
left a comment
Contributor
There was a problem hiding this comment.
This all looks reasonable. Happy to merge once the conflicts are resolved.
…ementations - Rebase onto main 0.9.0 and bump all TypeScript versions 0.5.2 -> 0.9.0 - Remove the lance-namespace-rest package and NATIVE_IMPLS; the core now ships only the LanceNamespace interface plus the generic connect/registerNamespaceImpl machinery, matching the Python and Java cores (implementations live elsewhere) - Publish under the @lance-format npm scope; name the generated client @lance-format/lance-namespace-fetch-client for consistency across the workspace - Generate the fetch client from docs/src/spec.yaml (the stale rest.yaml no longer exists) and fix the CI trigger path accordingly - Make patch-fetch-client.mjs discover API classes dynamically so new spec tags (Branch, MaterializedView) are exported without editing the script - Sync the LanceNamespace interface with the spec: add batchCommitTables, updateFieldMetadata, alterTableBackfillColumns, createMaterializedView, refreshMaterializedView, createTableBranch, listTableBranches, deleteTableBranch; remove createEmptyTable (dropped from the spec) - Align queryTable/countTableRows/namespaceExists/tableExists return types with the Python and Java cores (return the response models, preserving response context) - Publish the fetch client as dist-only (files: ["dist"]) - Update README and CONTRIBUTING to describe the two-package layout
jackye1995
force-pushed
the
xuanwo/namespace-client
branch
from
July 3, 2026 05:20
6554e99 to
0fb4d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the python's pattern and added a ts namespace client.
Key design points
corepackage only provides abstractions and class-path based implementation loadingNATIVE_IMPLSfollows Python-style aliases (rest,dir) and dynamic loadingtypescript/scripts/patch-fetch-client.mjsto keep build/lint/test and exports stable after regenValidation
make -C typescript buildmake -C typescript lintParts of this PR were drafted with assistance from Codex (with
gpt-5.3-codex) and fully reviewed and edited by me. I take full responsibility for all changes.