-
Notifications
You must be signed in to change notification settings - Fork 30
feat: native single-hop Expand via CSR adjacency index (Phase 2, #159) #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jja725
wants to merge
10
commits into
lance-format:main
Choose a base branch
from
jja725:feat/csr-native-expand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
76b9c2d
docs: add Phase 2 CSR native expand operator design
jja725 87ee0d3
docs: add Phase 2 CSR native expand implementation plan
jja725 3df32d7
feat(csr): add_edges_from_batch_with_columns for custom edge column n…
jja725 0c43408
refactor(native): promote lance_native_planner to module dir; add Nat…
jja725 5fc7664
feat(native): CsrExpandNode/Exec and expand_batch core
jja725 fce3edb
feat(native): RowMaterializer, LanceTakeNode/Exec, take_batch core
jja725 f2a1526
feat(native): CsrExtensionPlanner + CsrQueryPlanner physical planning
jja725 f622fb4
feat(native): LanceNativePlanner single-hop lowering with DataFusion …
jja725 2df8fcc
feat(native): wire LanceNative execution strategy + e2e parity tests
jja725 033a132
test(csr): add error-path tests and doc comment for add_edges_from_ba…
jja725 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard
UInt64requirement is not part of the native capability check. Existing repository fixtures useInt64node and relationship IDs, so a valid single-hop query is selected for native execution and then fails during physical planning withsrc_id column must be UInt64, instead of using the DataFusion fallback.Please either normalize all supported integer endpoint columns here, or inspect the relationship schema before selecting native execution and fall back when the ID representation is unsupported. Sparse/string IDs still require an explicit ID-to-ordinal mapping rather than a cast.