revert: keep documentation examples in echox - #3119
Merged
Merged
Conversation
Reverts 68ac4cf. The replacement examples and source reference live in labstack/echox#447.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert the documentation-only files added by #3117. The examples, config-field extractor, field baseline, and site checks now live in labstack/echox#447, alongside the website they support.
This removes the nested documentation module and the two documentation workflow jobs from Echo. It makes no changes to Echo's runtime API or root Go module. The paired
echoxPR compiles its examples against a recorded Echo commit and can check a proposed Echo checkout usingECHO_SOURCE_DIR.Verification
68ac4cf7e0b862001a9de7cdbc50d9447287a07c(11 documentation files removed).git diff --checkpassed.echoxsite and examples build locally in echo v2 websocket stack overflow #447.Related: echox#448. A minimal Echo-side cross-repository gate can be discussed separately after the repository boundary is agreed.