Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause found during validation
The loaded regression exposed an existing RWKV7 forward failure. Each recurrent step computed
state @ r[..., None]as[B, H, D, 1]and stacked those tensors without removing the final singleton axis. This produced[B, T, H, D, 1], while the following per-head normalization expects[B, T, H, D]and weights shaped[H, D]. The pre-fix GPU run aborted with a native broadcast error between(2,4)and(1,1,2,4,1).The fix squeezes only the matrix product's final axis, yielding the documented per-step
[B, H, D]output and stacked[B, T, H, D]sequence tensor. Recurrent state remains[B, H, D, D].Test plan
rwkv7_focused suite after the shape fix: 5 passed, including the loaded-model contract test in 0.64 seconds.test-fastrebuild after the shape fix: passed in 2 minutes 22 seconds.git diff --checkDependency refresh
The validation above was recorded before merging main commit
4b0c4519from PR #2298. The current branch merged that MLX pin and overlay update at9b05507bwithout changingsrc/models/rwkv7.rs(SHA-256fa18e8e5e33f4af42fe7c7c8574e55db8578f90724d3a70d0cad4a7cf10adea7). Focused runtime revalidation on the new pin is pending; the checked results remain historical evidence for the reviewed model source.Closes #2286