Repository navigation
feat(BA-8384): add the runtime_variant seed kind - #15470
Merged
HyeockJinKim merged 3 commits intoOct 13, 2026
Merged
Conversation
github-actions
Bot
added
size:L
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation follows existing seed and entity-upserter patterns with comprehensive coverage of the stated behavior.
0 open findings
What changed in this PR
Adds runtime_variant support to the manager seed framework, including validation, persistence, RBAC membership, and idempotence coverage.
Changes:
- Registers version 1 runtime-variant seeds.
- Adds an ID-keyed runtime variant upserter.
- Tests validation, conflicts, overwrite behavior, scopes, and idempotence.
| File | Description |
|---|---|
src/ai/backend/manager/models/runtime_variant/upserters.py |
Implements runtime variant upserts. |
src/ai/backend/manager/seed/runtime_variant/seed.py |
Defines the seed item schema and write mapping. |
src/ai/backend/manager/seed/runtime_variant/__init__.py |
Adds the seed package. |
src/ai/backend/manager/seed/factory.py |
Registers the new seed kind. |
tests/unit/manager/seed/conftest.py |
Adds runtime variant fixtures and tables. |
tests/unit/manager/seed/runtime_variant/BUILD |
Configures the new test target. |
tests/unit/manager/seed/runtime_variant/test_seed.py |
Tests validation, planning, and checking. |
tests/unit/manager/seed/runtime_variant/test_apply.py |
Tests database writes and conflicts. |
tests/unit/manager/seed/test_seed_idempotence.py |
Adds runtime variant idempotence coverage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HyeockJinKim
force-pushed
the
BA-8384-seed-runtime-variant
branch
from
October 12, 2026 17:47
85df8e6 to
9d2da78
Compare
HyeockJinKim
changed the base branch from
main
to
BA-8397-seed-resource-policy
October 12, 2026 17:47
- RuntimeVariantUpserter writes a runtime variant under its stated id, created in global and public - RuntimeVariantSeed (version 1) validates the name against the column length and writes through the upserter - A name another row holds is refused by the unique constraint and skips only that item Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
HyeockJinKim
force-pushed
the
BA-8397-seed-resource-policy
branch
from
October 13, 2026 03:12
84db658 to
2a06e3e
Compare
HyeockJinKim
force-pushed
the
BA-8384-seed-runtime-variant
branch
from
October 13, 2026 03:12
9d2da78 to
1b92ebb
Compare
HyeockJinKim
added this pull request to stack #15517
October 13, 2026 03:13
HyeockJinKim
removed this pull request from stack #15517
October 13, 2026 03:51
HyeockJinKim
merged commit Oct 13, 2026
6ff0dcc
into
BA-8397-seed-resource-policy
8 of 11 checks passed
github-actions
Bot
added
size:XL
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on BA-8397-seed-resource-policy
Summary
RuntimeVariantUpserterwrites a runtime variant under its stated id, created inglobalandpublic.RuntimeVariantSeed(version 1) is theruntime_variantkind's item.nameis checked against the column length; the optional fields default to the column defaults.Test plan
tests/unit/manager/seed/runtime_variant/: model validation, planning,mgr seed check, apply, skip on an existing row, overwrite, name collision.tests/unit/manager/seed/test_seed_idempotence.py: applying again changes no row.Resolves BA-8384
🤖 Generated with Claude Code