feat: cache cve-ecosystem-distribution endpoint#2338
Open
domzoric wants to merge 1 commit into
Open
Conversation
The endpoint aggregates the whole global vuln db on every request, which takes 15-20s. The data only changes when the vulndb mirror runs (~hourly) and has no org/user/request dimension, so a single in-process value with a 1h TTL and singleflight (same pattern as the org statistics cache) serves it instantly after the first computation. Closes l3montree-dev#2222 Signed-off-by: domzoric <zoric.dominik0511@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/api/v1/vulndb/cve-ecosystem-distribution/endpoint takes 15-20s per request because it aggregates the whole global vuln db every time (COUNT(DISTINCT cve_id)over the fullcve_affected_componentjoin table).The data only changes when the vulndb mirror runs (~hourly) and has no org/user/request dimension, so this adds a single in-process cached value with a 1h TTL and
singleflightto prevent concurrent recomputations — the same pattern already used for the org statistics cache instatistics_service.go. The query logic itself is unchanged, just extracted intocomputeCVEEcosystemDistribution.The cache hangs off the controller as a pointer so the existing value-receiver methods don't copy the lock.
Tests
VulnDBControllerwas added to the fxTestAppwiring for thisCloses #2222