fix(bearings): support oversized fleet snapshots - #1964
Open
coreldh wants to merge 2 commits into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix PR 1964 so the large-fleet Bearings snapshot transport remains compatible with stock macOS Bash, its CI test inventory matches the new scale regression, and the existing open PR is validated and brought into the repository's no-mistakes publication custody. Do not force-push, merge, auto-merge, approve, or open a duplicate PR. The unrelated remote orphan-reap timeout was tested at origin/main and this head and also fails on PR 1965, so it is pre-existing or environment-dependent unless the pipeline establishes otherwise.
What Changed
jqstages instead of passing large payloads through command arguments.Risk Assessment
✅ Low: The diff consistently replaces large JSON argv transport with stdin streaming, retains projection semantics, and adds a macOS-scale regression plus matching CI inventory count.
Testing
Ran the focused fleet/Bearings suite on stock macOS Bash 3.2.57, then replayed the large-fleet path above ARG_MAX and captured the public Bearings JSON showing the in-flight task and all 320 queued gates; the CI inventory check matches the new 16-test expectation. This is a CLI-only change, so the transcript is the reviewer-visible product evidence. No worktree files were created or changed by testing.
Evidence: Large-fleet Bearings CLI output
BEARINGS_E2E= {"schema":"fm-bearings.v1","in_flight_ids":["argv-scale-live"],"queued_gate_count":320,"gate_ids":["argv-scale-0","argv-scale-319"]}Evidence: CI inventory check
CI snapshot inventory: expected=16 observed=16Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
/bin/bash tests/fm-fleet-snapshot-view.test.shEvidence-only end-to-end replay of the oversized-inventory fixture under/bin/bashCI-equivalent snapshot inventory assertion:/bin/bash tests/fm-fleet-snapshot-view.test.shwith observedok -inventory checked against 16✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.